lizzie
858f9e5aea
[docs] Various grammar fixes, fix dead links, update deps.md, merge RDOC into Debug.md ( #4315 )
...
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions ).
- [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md )
- [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md ) to the best of my ability.
-------------------
updates deps.md (freebsd had a package that didnt exist, oops)
netbsd also had outdated packages
moved windows caveats into the user guide (because well, those are user stuff, not build caveats)
MANY redundant wording removals (especially on dynarmic)
proper capitalization of Eden, Dynarmic, Amiibo, and CLion
fixed discord link on metainfo as well
also fixed file associations as well otherwise installed eden wont have icon over NSP/XCI/etc files
"please" is filler
fixes a HANDFUL of dead links as well
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4315
Reviewed-by: crueter <[email protected] [email protected]
2026-09-01 06:45:47 +02:00
lizzie
cb9ec1dc1a
[dynarmic] fix perf regression due to hard CPUID queries ( #4328 )
...
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions ).
- [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md )
- [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md ) to the best of my ability.
-------------------
should fix whatever issue bruno had on Windows
basically CPUID ctor object for xbyak is very VERY heavy, so we just move that to a static we do once on program startup instead!
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4328
Reviewed-by: CamilleLaVey <[email protected] [email protected]
2026-08-31 23:51:56 +02:00
lizzie
f7e5ceeacb
[video_core/buffer_cache] fix PAGE_SHIFT/BSD macro clash on Linux, *BSD ( #4329 )
...
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions ).
- [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md )
- [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md ) to the best of my ability.
-------------------
PAGE_SHIFT is a macro (sys/user.h on linux, machine/params.h on FBSD), dont name stuff that
https://stackoverflow.com/questions/77611721/get-page-shift-value-in-user-space
BSD is also a macro
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4329
Reviewed-by: CamilleLaVey <[email protected] [email protected]
2026-08-31 21:34:01 +02:00
lizzie
106a61c943
[core/file_sys] fix IPS not applying due to wrong NSObuild-id ( #4323 )
...
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions ).
- [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md )
- [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md ) to the best of my ability.
-------------------
NSO build id was being read wrongly... oops
also fixed some minor issues as well
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4323
Reviewed-by: Shinmegumi <[email protected] [email protected]
2026-08-30 20:08:40 +02:00
lizzie
e5b656e372
[common/logging] Fix long logs, remove clutter on Android logcat ( #4310 )
...
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions ).
- [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md )
- [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md ) to the best of my ability.
-------------------
logs normally are like this:
```
08-27 02:58:48.188 12511 4743 W YuzuNative: [18534.062505] Shader <Warning> shader_recompiler/frontend/maxwell/translate/impl/move_special_register.cpp:141:Read: (STUBBED) SR_WSCALEFACTOR_XY
08-27 02:58:48.188 12511 4743 W YuzuNative: [18534.062513] Shader <Warning> shader_recompiler/frontend/maxwell/translate/impl/move_special_register.cpp:144:Read: (STUBBED) SR_WSCALEFACTOR_Z
08-27 02:58:48.188 12511 4743 W YuzuNative: [18534.062520] Shader <Warning> shader_recompiler/frontend/maxwell/translate/impl/vote.cpp:50:VOTE_vtg: (STUBBED) called
08-27 02:58:48.188 12511 4743 W YuzuNative: [18534.062523] Shader <Warning> shader_recompiler/frontend/ir/ir_emitter.cpp:267:GetFlowTest: (STUBBED) FCSM_TR
```
bunch of redundant info imo
instead they should just be
```
08-27 02:58:48.188 12511 4743 W YuzuNative: Shader shader_recompiler/frontend/maxwell/translate/impl/move_special_register.cpp:141:Read: (STUBBED) SR_WSCALEFACTOR_XY
08-27 02:58:48.188 12511 4743 W YuzuNative: Shader shader_recompiler/frontend/maxwell/translate/impl/move_special_register.cpp:144:Read: (STUBBED) SR_WSCALEFACTOR_Z
08-27 02:58:48.188 12511 4743 W YuzuNative: Shader shader_recompiler/frontend/maxwell/translate/impl/vote.cpp:50:VOTE_vtg: (STUBBED) called
08-27 02:58:48.188 12511 4743 W YuzuNative: Shader shader_recompiler/frontend/ir/ir_emitter.cpp:267:GetFlowTest: (STUBBED) FCSM_TR
```
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4310
Reviewed-by: crueter <[email protected] [email protected]
2026-08-30 08:24:00 +02:00
lizzie
297e797a32
[hle/kernel] remove flusher thread from OutputDebugString ( #4291 )
...
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions ).
- [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md )
- [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md ) to the best of my ability.
-------------------
Unneeded abstraction?
either way it seems this thread is not required
anyone thinking otherwise feel free to lmk
directly contradicts with #4290
and #3744
Remember that messages will be displayed out of order
this can make actual debugging much harder I'm afraid
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4291
Reviewed-by: MaranBr <[email protected] [email protected]
2026-08-30 08:18:50 +02:00
Lizzie and Samuel and CamilleLaVey
45b6ecff05
[vulkan, vk_pipeline_cache] PSO Optimizations ( #4294 )
...
PR/Commit Owner: CamilleLaVey
This PR prevents the recompilation of shaders when a new session has been started, based on data found on the recompiler, each new session does still recompile already cached shader cache, reducing the reaction and speed of games by at certain level, this prevent the warm-up with post sessions, only needed the initial warm-up and works globally for all games.
Co-authored-by: CamilleLaVey <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4294
Reviewed-by: CamilleLaVey <[email protected] [email protected]
2026-08-30 08:15:29 +02:00
lizzie
672bcbae01
[file_sys] robust-er IPSwitch compiler ( #3911 )
...
this PR reworks IPS parser to be less stupid
what do i mean by this? well generally give it a bit of
love so it doesn't do a lot of unsound allocations
also simplify the logic greatly (and use memcmp() string idiom
instead of trusting the compiler so blindly...)
no this doesn't mean to uber optimize IPS to handle 999 gb/s
it's more so it doesn't outright crash with edge cases
as the previous codebase was quite spaghetty
also the major overhead is obviously the vector shenanigans
and the I/O -- but thats out of scope
Test that IPSwitch mods still properly work WITH ANY GAME
IF THERE IS ANY REGRESSION IN SOME GAME/MOD THEN
TELL ME
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/3911
Reviewed-by: crueter <[email protected] [email protected]
2026-08-30 08:10:51 +02:00
lizzie
ccf3de02cf
[dynarmic] optimise BlockOfCode to use less memory ( #4303 )
...
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions ).
- [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md )
- [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md ) to the best of my ability.
-------------------
removes unique_ptr indireciton with argCallback (lmao)
reorders jitState to be more cache friendly and yadda yadda
removes redundant BlockOfCode& ptr on constantPool
reorder blockOfCode to be btter
update dynarmic because it removes 3kb worth of useless data :)
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4303
Reviewed-by: Maufeat <[email protected] [email protected]
2026-08-30 07:43:21 +02:00
lizzie
f4a8f9421a
[common/net] fix linking errors due to C++11 ABI typedef mishandle ( #4260 )
...
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions ).
- [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md )
- [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md ) to the best of my ability.
-------------------
basically bunch of linking errors due to gcc not liking
to compile HFA/whatever typedef stuffs
this is on non-x86_64 arch, ppc64
compiler where this occurs
```
gcc (Debian 14.2.0-19) 14.2.0
Copyright (C) 2024 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
```
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4260
Reviewed-by: MaranBr <[email protected] [email protected]
2026-08-29 20:59:57 +02:00
lizzie
119291dc77
[qt_common/discord] fix boxart not being used ( #4275 )
...
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions ).
- [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md )
- [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md ) to the best of my ability.
-------------------
issue was first reported here
https://github.com/eden-emulator/Issue-Reports/issues/607
tl;dr wrong boolean, now boxarts should work
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4275
Reviewed-by: Maufeat <[email protected] [email protected]
2026-08-28 03:46:36 +02:00
lizzie
f7dbff2157
[core/hle/services/am] Fix MK8D crash ( #4313 )
...
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions ).
- [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md )
- [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md ) to the best of my ability.
-------------------
This fixes a random mk8d crash when connecting via LDN
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4313
Reviewed-by: CamilleLaVey <[email protected] [email protected]
2026-08-28 03:44:45 +02:00
lizzie
b859d7fdf4
[dynarmic/backend/exception_handler] normalize EH for arches, use LOG_ERROR instead of fmt::print ( #4283 )
...
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions ).
- [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md )
- [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md ) to the best of my ability.
-------------------
this should simplify a bit of code logic
akin to NetBSD's UC_CONTEXT_PC...
additionally use LOG_ERROR so the
"unhandled ..."
is logged unto a file
before sigsegv'ing
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4283
Reviewed-by: Maufeat <[email protected] [email protected]
2026-08-28 02:30:18 +02:00
lizzie
f635827fa6
[common/stb] remove unused I/O funcs from non-LTO builds, use common/stb.h on ns service ( #4282 )
...
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions ).
- [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md )
- [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md ) to the best of my ability.
-------------------
- remove I/O functions that are unused from LTO builds
- use common/stb.h on ns
simple change really, not much to explain here
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4282
Reviewed-by: Maufeat <[email protected] [email protected] [email protected]
2026-08-28 02:29:52 +02:00
lizzie
243453c172
[dynarmic, loong64] fix build error due to new term handlers ( #4286 )
...
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions ).
- [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md )
- [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md ) to the best of my ability.
-------------------
trivial fix
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4286
Reviewed-by: Maufeat <[email protected] [email protected]
2026-08-28 02:24:39 +02:00
lizzie
39158b67a7
[audio/sdl3] fix mismatches OS mixer settings for sdl3/cubeb audio backends ( #4298 )
...
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions ).
- [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md )
- [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md ) to the best of my ability.
-------------------
basically makes it so SDL3 and cubeb audio backends now share the same
identifier string so OS mixers (ok a bit of a misnormer, its like pulseaudio
pipewire and such, but yknow what i mean) -- dont conflate due to the
fact that "Eden" != "yuzu Latency Getter".
fix taken from pcsx2 https://github.com/PCSX2/pcsx2/pull/12312
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4298
Reviewed-by: Maufeat <[email protected] [email protected]
2026-08-28 01:50:55 +02:00
lizzie
faaf1bac64
[common/logging] Fix logging overflow on logging settings ( #4308 )
...
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions ).
- [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md )
- [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md ) to the best of my ability.
-------------------
Apparently on FBSD we have plenty of stack space -- but not on Linux.
Just fixes a stack overflow thing.
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4308
Reviewed-by: MaranBr <[email protected] [email protected]
2026-08-26 20:38:52 +02:00
lizzie and CamilleLaVey
d9336ce6ce
[common, settings] Fixes misaligned Aniso levels ( #4295 )
...
PR/Commit Owner: CamilleLaVey
Just quick fixes to ANISO bugged level selector, removes x32 and x64 from choices, also fixes the none value to actully use default.
Co-authored-by: CamilleLaVey <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4295
Reviewed-by: Maufeat <[email protected] [email protected]
2026-08-24 00:06:11 +02:00
Samuel and CamilleLaVey
86ba79b1ba
[vulkan, sgsr] Adjustments to SGSR implementation ( #4293 )
...
PR/ Commit Owner: CamiileLaVey
This change has specified fixes on the SGSR initial implementation, it brought a wider sharpening level limits and better image quality.
Co-authored-by: CamilleLaVey <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4293
Reviewed-by: CamilleLaVey <[email protected] [email protected]
2026-08-23 23:36:24 +02:00
lizzie
b610b03d29
[common/logging] eliminate uneeded std::string{} allocations per each logging ( #4273 )
...
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions ).
- [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md )
- [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md ) to the best of my ability.
-------------------
the idea is simple, `std::string{}` adds pressure to the memory allocator
so whats the best next thing we can do? well of course use our stack
its plenty, but we shouldn't be greedy either, BUFSIZ should be a fair amount of
space for any would-be messages anyways
the main idea behind this PR is to remove std::string{} allocations
done with libfmt, that way we have 0-allocs per logging entry
this should 100% remove pressure uneeded from the memory allocator
we should only allocate things that are important, we can use our
trusty fast stack for any string manip we need to do
not await/global lock or do evil things with the memory allocator
obviously stack is thread local already sooo... this is even better
than having to deal with malloc()/free() in any capacity whatsoever
and no clang can't heap ellide this (how would you even?)
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4273
Reviewed-by: Maufeat <[email protected] [email protected]
2026-08-23 22:37:17 +02:00
lizzie
421e0b834c
Revert "[dynarmic] Remove Ignore Global Monitor from CPU Accuracy Auto ( #3846 )" ( #4276 )
...
This reverts commit 3a823de605https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions ).
- [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md )
- [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md ) to the best of my ability.
-------------------
kills performance and doesn't fix graphical glitches
(according to gido)
"It improved nothing but kills performance on default setting"
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4276
Reviewed-by: Maufeat <[email protected] [email protected]
2026-08-23 22:10:22 +02:00
lizzie
0465292a81
[docs] overview doc for newcomers ( #4266 )
...
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions ).
- [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md )
- [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md ) to the best of my ability.
-------------------
documents basic stuff about the emu and "hey eden is HLE" (like most yuzu forks!)
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4266
Reviewed-by: CamilleLaVey <[email protected] [email protected]
2026-08-18 19:00:26 +02:00
lizzie
a41a98028a
[hle/service] stub missing homebrew services, fix NPad/caps crashes ( #4264 )
...
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions ).
- [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md )
- [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md ) to the best of my ability.
-------------------
this PR adds various missing services (acc:e, acc:e:u1)
to expand homebrew compatibility
notably this also fixes NPad related crashes due to nullref
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4264
Reviewed-by: Maufeat <[email protected] [email protected]
2026-08-18 18:11:33 +02:00
lizzie
e7a931d06b
[eden-cli] rework loop to use new SDL3 event dispatch system ( #4108 )
...
modernized into the new SDL3 API for event dispatching.
also stopped using the periodic comparison and just added a SDL timer like it wants us to do
is it better than before? well it's certainly more portable now. docs say this improves battery usage on busywaits for event polling.
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4108
Reviewed-by: Maufeat <[email protected] [email protected]
2026-08-12 18:10:24 +02:00
lizzie
7731b5bc86
[core/hle/kernel/svc] demote ResetSignal log Debug->Trace ( #4161 )
...
I don't see why it's LOG_DEBUG if WaitSynchronization is LOG_TRACE, leaves incomplete data
may as well bundle it to trace with the others? :)
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4161
Reviewed-by: CamilleLaVey <[email protected] [email protected]
2026-08-09 14:13:27 +02:00
lizzie
c4ab2f6b9e
[cmake] Add ENABLE_WERROR option ( #4080 )
...
Should warnings be errors? that's a philosophical debate which I can only answer with "no, but if you think otherwise here is an option for you"
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4080
Reviewed-by: crueter <[email protected] [email protected]
2026-08-09 02:56:28 +02:00
lizzie
a43664c0fd
[audio_core] Fix jamboree crash due to OOB access ( #4252 )
...
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions ).
- [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md )
- [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md ) to the best of my ability.
-------------------
PLEASE test diablo 3 or ANY game that's sensitive to audio changes
Just TEST that there's NO regressions on the audio front
this fixes a rare Jamboree crash with audio DSP
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4252
Reviewed-by: CamilleLaVey <[email protected] [email protected]
2026-08-05 21:56:18 +02:00
lizzie
a0f1cd1baf
[hid_core] fix NPad crash on pikmin 4 due to nullref ( #4249 )
...
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions ).
- [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md )
- [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md ) to the best of my ability.
-------------------
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4249
Reviewed-by: CamilleLaVey <[email protected] [email protected]
2026-08-05 20:55:01 +02:00
lizzie
ba9130fbf9
Revert "[externals] remove SPIRV-Headers and SPIRV-Tools ( #3989 )" ( #4247 )
...
This reverts commit ee197e6222https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions ).
- [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md )
- [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md ) to the best of my ability.
-------------------
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4247
Reviewed-by: CamilleLaVey <[email protected]
2026-08-04 02:03:18 +02:00
lizzie
7d5f390ffb
[android] fix crash when loader for invalid file is found ( #4003 )
...
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4003
Reviewed-by: CamilleLaVey <[email protected]
2026-08-04 01:52:32 +02:00
lizzie
8fe1e6efa2
[core/file_sys] implement IApplicationFunctions::GetPseudoDeviceId; common PatchManager::GetNACP for base|updates ( #4159 )
...
a bit of refactoring so there's less code duplication...
probably a good idea to make it a lambda anyways
maybe this is why QLauncher didn't have proper DLCs and updates?
either way "GetPseudoDeviceId" is now implemented (still stubbed) with a proper hash instead of just 0
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4159
Reviewed-by: Maufeat <[email protected] [email protected]
2026-08-04 01:50:54 +02:00
lizzie
ee197e6222
[externals] remove SPIRV-Headers and SPIRV-Tools ( #3989 )
...
only dep that uses it is sirit, but sirit already has it's own bundled SPIRV-Headers... so
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/3989
Reviewed-by: Maufeat <[email protected] [email protected]
2026-08-03 00:00:55 +02:00
lizzie
39763e7321
[core/hle/services/am] nuke ButtonPoller and Mouse thread ( #4229 )
...
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions ).
- [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md )
- [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md ) to the best of my ability.
-------------------
doesn't even do anything now, please check if controller i/o is affected by this change
this should also fix latency issues with the mouse
the ButtonPoller thread isn't longer required since we update the state immediately with the .on_change callback registered
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4229
Reviewed-by: CamilleLaVey <[email protected]
2026-07-26 05:11:03 +02:00
lizzie
dc1486485b
[core/hle/service] move 'loader'+'jit' to guest thread ( #4148 )
...
loader is barely called whereas audio for example is called super often
thus demote loaderr
jit is only ever used by Super Mario 3D stars, and no other
games require this to be a separate jit thread
additionally even of 3D stars this is called often chary
so no; we dont need a dedicated thread for it either way
this pr should help low power devices/devices with less cores/threads
to schedule the existing emulator threads more efficiently
also moving to guest means the CPU threads get more loaded with
stuffings, which is a good thing as most of the time theyre
sleeping and/or waiting for a mutex
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4148
Reviewed-by: Maufeat <[email protected] [email protected]
2026-07-25 23:46:59 +02:00
lizzie
f561a10bd8
[core/core] GPU initialize before CPU ( #4228 )
...
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions ).
- [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md )
- [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md ) to the best of my ability.
-------------------
should fix issue where vulkan dies trying to do locks or whatever, since CPU will infinitely stall or whatever
tl;dr: dynarmic is getting too good and outpacing initialization
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4228
Reviewed-by: Maufeat <[email protected] [email protected]
2026-07-25 23:34:22 +02:00
lizzie
6272f8ab24
[hle/service/am] make EventObserver use jthread() ( #3971 )
...
I don't remember why this wasn't done earlier, did I miss something or I purpousefully avoided this due to an issue?
Please test NO HANGS when opening/closing/playing
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/3971
Reviewed-by: MaranBr <[email protected] [email protected]
2026-07-25 22:33:01 +02:00
lizzie
eebb4bd91e
[eden-cli] add extra CLI options -n/-x/-s ( #4173 )
...
from wasm PR:
- `--null-render/-n`: Forces the usage of the "Null" render backend irrespective of settings.
- `--filter/-x`: Sets the debug log filter irrespective of settings.
- `--singlecore/-s`: Forces single-core regardless of settings.
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4173
Reviewed-by: MaranBr <[email protected] [email protected]
2026-07-25 22:20:31 +02:00
lizzie
58dee53305
[fmt] use {#:x} instead of 0x{:#x} ( #4170 )
...
continuation of #309 but applying to even more files than before :)
also makes them lowercase because `0xfafafa` is better as `0XFAFAFA`
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4170
Reviewed-by: CamilleLaVey <[email protected] [email protected]
2026-07-25 21:47:07 +02:00
lizzie
7b13113fbe
[dynarmic] flatten terminal variants to not use recursive pointers ( #4218 )
...
take If{then, else} for example
100% of the time If{} only has a leaf terminal, supporting If{If{}, If{}} is very dumb and we don't need that
so remove that
this reduces
> The recursive_wrapper class template has an interface similar to a simple value container, but its content is allocated dynamically
aka. uses malloc and spams heap EVERYTIME A CONDITIONAL TERMINAL IS USED
thats bad tbf, i dont like it, removing it is better for general speedup
also we dont REALLY need if{if{if{if{}}}} support, like really
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4218
Reviewed-by: MaranBr <[email protected] [email protected]
2026-07-25 21:43:58 +02:00
lizzie
5b4dc32c1a
[core/hle/service/am] Stub ISelfController::IsIlluminanceAvailable ( #4163 )
...
MelonDS calls this and otherwise seems innocuous to implement.
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4163
Reviewed-by: Maufeat <[email protected] [email protected]
2026-07-24 22:23:09 +02:00
lizzie
89004124a5
[video_core] use bool params for read/writes and cascade them thru the calltree ( #4001 )
...
should make codegen a tad bit better and reduce icache pressure for what is otherwise a glorified memcpy
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4001
Reviewed-by: Maufeat <[email protected] [email protected] [email protected]
2026-07-18 21:01:58 +02:00
lizzie
9a0e6b3c28
[msvc] fix error with new <T>bitfields ( #4196 )
...
fixes MSVC build errors
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4196
Reviewed-by: CamilleLaVey <[email protected]
2026-07-13 21:12:13 +02:00
lizzie
6295d23581
[qt] remove stale compat list setting ( #4202 )
...
if we are REALLY going thru for removing the entire game compat list
subsystem, we ought to remove the setting itself
I kept this PR separate because we MAY want to introduce emuready
compatibility, so keeping the setting will keep compatibility with
older setting files from users...
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4202
Reviewed-by: MaranBr <[email protected] [email protected]
2026-07-12 20:24:35 +02:00
lizzie
7f85c6e282
[qt] nuke game compat list (again) ( #4201 )
...
we have no use for it
it's dead code
most of the time users just complain about how the list isn't updated
ok so what if we update it? great now its more noise added to the git, awesome
even if we constantly update it, we introduce new breakage that makes keeping
track of things extremely difficult
either we integrate with emuready (would violate self containment principles)
or we integrate with emuready in a similar fashion to eden news outlet
(where we cache the list with some TTL of like 60 mins or whatever)
that would be better respecting of "self containment" but would probably
require having a quick way to update the list additively, probably filtered to the user's
device instead of a global thing, and i dont think emuready has that granularity
nor we have the "connect this to that" for the api stuffs
another (which is what i propose here) is throw everything out of the window
until someone can come up with something better
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4201
Reviewed-by: Maufeat <[email protected] [email protected]
2026-07-12 09:32:11 +02:00
lizzie and CamilleLaVey
3fd6eeaf9f
Revert #3970 #4177 ( #4187 )
...
3970 revert fixes crash caused by scheduler
4177 fix mario galaxy and metroid prime 4 not booting
Co-authored-by: CamilleLaVey <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4187
Reviewed-by: MaranBr <[email protected]
2026-07-09 19:02:26 +02:00
lizzie
41762940d6
[common] rework BitField and BitUtil, use concepts whenever possible ( #4076 )
...
test no regressions especially on Liiinux
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4076
Reviewed-by: CamilleLaVey <[email protected] [email protected]
2026-07-09 03:47:04 +02:00
lizzie
c2e74a9380
[common] remove DetachedTasks object usage ( #4096 )
...
this was only ever used for announce room json on one single instance
this object is pretty much a danger to society and shouldnt exist, especially since its:
a) a singleton
b) spawns objects out of thin air
c) doesn't respect RAII and can outlive its parent objects (big no no)
generally we shouldnt endorse objects like these in the future, but alas, it existed, now it has to begone
additionally there is a similar object in KWorkerTaskManager but it's not as egregious as this one.
check that this didnt break the usual announce room json logic
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4096
Reviewed-by: CamilleLaVey <[email protected] [email protected]
2026-07-09 03:46:06 +02:00
lizzie
e401414aab
[core/hle] update fw constants to 22.5.0, ams -> 1.11.2, implement /digest file ( #4165 )
...
adds `/digest` file implementation
alongisde the hashes and constants for firmwareless installs
and yes ams updated as well
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4165
Reviewed-by: Maufeat <[email protected] [email protected]
2026-07-09 03:45:30 +02:00
lizzie
e662108584
[fs] use recursive_directory_iterator since MSVC CRT no longer should bug out ( #3670 )
...
SURELY, microslop already fixed its megaslop?
basically read the comment (now gone); MSVC is evil, but it cant still be this evil right... right?!?!?! it's been 2 years surely not!
mainly because this helps deep scan (in theory); android should see slight improvments for big game libraries
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/3670
Reviewed-by: MaranBr <[email protected] [email protected]
2026-07-07 20:26:10 +02:00
lizzie
29f712d3b5
[core/device_memory_manager] use more pointer/iterator stable std::vector<> instead of deque<> for multi address scatter/gather ( #4098 )
...
this SHOULD fix a specific issue where a deque can be reallocated causing spurious crashes
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4098
Reviewed-by: CamilleLaVey <[email protected] [email protected]
2026-07-07 20:17:29 +02:00
lizzie
ae75ba4883
[shader_recompiler/ir] fix potential CBuf collision when count mismatches ( #4097 )
...
this should make disjoint counts be handled as different cbufs for the cbuf cache
this fixes TIC asserts on PKZA
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4097
Reviewed-by: MaranBr <[email protected] [email protected]
2026-07-07 20:16:21 +02:00
lizzie
7b750bf5bb
[hid_core, input_common] use std::numbers::pi{_v} instead of re-defining ( #4160 )
...
don't reinvent the wheel, simple as that.
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4160
Reviewed-by: MaranBr <[email protected] [email protected]
2026-07-07 20:13:33 +02:00
lizzie
94e9c2bd74
[common] remove presumed 'hot path' for QPC of 10MHz on SteadyClock::Now() ( #4162 )
...
while this may be true, it isn't required to have this quick path for this function because:
a) arm64
b) counter/freq and counter%freq is a single idiv
c) 2 muls, 2 div isnt that insanely expensive
d) `static_assert(period::den % TenMHz == 0)`
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4162
Reviewed-by: MaranBr <[email protected] [email protected]
2026-07-07 20:03:27 +02:00
lizzie
9677522e6c
[core/hle/kernel/svc] add missing CanContain check for {Un}MapProcessCodeMemory, remove 4KB align func ( #4164 )
...
does what it says, adds a missing check for that specific SVC
also removes that 4kb "helper" function which is just a fancy "IsAligned"
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4164
Reviewed-by: MaranBr <[email protected] [email protected]
2026-07-07 20:02:26 +02:00
lizzie
f423471cc0
[*, docs] remove UTF8 and make docs ASCII only ( #4166 )
...
except for the AI policy doc which uses output for demonstrative purposes
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4166
Reviewed-by: MaranBr <[email protected] [email protected]
2026-07-07 20:01:11 +02:00
lizzie
ce043aceb9
[core/hle/service] remove duplicate Core::System& from some ServiceFramework ( #4171 )
...
services inheriting from ServiceFramework already have an accessible
system pointer from the inheritance
adding an extra pointer (m_system, often) isn't required and tis
entirely redundant.
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4171
Reviewed-by: MaranBr <[email protected] [email protected]
2026-07-07 19:59:58 +02:00
lizzie and CamilleLaVey
1643d8766f
[vk] invalidate shader cache automatically if !=driverId or !=driverVersion ( #4174 )
...
this integrates neatly into the existing GraphicsPipelineKey system
no need for extra funcs :)
Signed-off-by: lizzie <[email protected] [email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4174
Reviewed-by: MaranBr <[email protected] [email protected]
2026-07-07 19:57:45 +02:00
lizzie
fe1b8ff0ab
[input_common] Fix GetButtonMappingForDevice() when joystick doesn't have a gamepad associated with it ( #4172 )
...
from PS4 PR - this should help fix the case where a controller
doesn't have an associated gamepad and thus its not automatically
configured.
this should fix that :)
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4172
Reviewed-by: MaranBr <[email protected] [email protected]
2026-07-07 19:54:15 +02:00
lizzie
f22fd1714b
[dynarmic] use LinkBlockFast for branches which are guarnateed to be unconditional (or conditionally unconditional) ( #4177 )
...
CBZ is basically
```c
if (thing) {
jump(A);
} else {
jump(B);
}
```
those jumps are locally unconditional so we can add the LinkBlockFast
without much repercussions for a small win in JIT opts
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4177
Reviewed-by: MaranBr <[email protected] [email protected]
2026-07-07 19:53:13 +02:00
lizzie
6119e8fad2
[hid_core] fix LM2 crash due to callbacks not being removed properly ( #4178 )
...
the function returned the key AFTER this one, which points to an invalid object
basically its like "oh im returning the index AFTER Myself"
off-by-1 error basically; now it returns OUR own key.
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4178
Reviewed-by: MaranBr <[email protected] [email protected]
2026-07-07 19:52:22 +02:00
lizzie
bfc0e60333
[externals/stb] only include JPEG functions, disable all others ( #4179 )
...
we use JPEG only with STB, dont need the others
which are included in the final binary, after gc+lto
this doesnt affect stb_dxt, which still includes all required BCn stuff
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4179
Reviewed-by: MaranBr <[email protected] [email protected]
2026-07-07 19:51:51 +02:00
lizzie
072be286d1
[shader_recompiler] fix META_TABLE/NUM_ARGS table being duplicated per TU that included opcodes.h ( #4180 )
...
small oopsie; we dont need 6 copies of the same 22KB table
(removes 5*22 = 110 KB worth of redundant stuff)
this also enforces static on the types defined in the header so they arent memoized into a non-inlined value (aka. compiler just grabs value instead of well, yknow, assuming its a constant area)
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4180
Reviewed-by: MaranBr <[email protected] [email protected]
2026-07-07 19:50:56 +02:00
lizzie
4c65780f11
Revert "[common/dynamic_library] fix AUR build error ( #4156 )" ( #4157 )
...
This reverts commit a9c4c8aefdhttps://git.eden-emu.dev/eden-emu/eden/pulls/4157
Reviewed-by: CamilleLaVey <[email protected] [email protected]
2026-07-02 22:07:37 +02:00
lizzie
a9c4c8aefd
[common/dynamic_library] fix AUR build error ( #4156 )
...
not gonna question why there was an ifdef there
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4156
Reviewed-by: CamilleLaVey <[email protected] [email protected]
2026-07-02 19:49:19 +02:00
lizzie and CamilleLaVey
a769505a45
[vk, ogl] Remove dedicated precomputed swizzle table; use shorter inline table in block_linear swizzle shaders ( #4146 )
...
old table = 64 * 8 * sizeof(u32) = 512 * 4 = 4096 bytes
new table = 8 * sizeof(u32) = 8 * 4 = 32 bytes
the expression
```glsl
return ((pos & 0x0180) >> 1)
| ((pos & 0x0040) >> 2)
| ((pos & 0x0020) << 3)
| ((pos & 0x0010) << 1)
| ((pos & 0x000f) << 0);
```
is equivalent for generating the table but idk if we'd want that
Signed-off-by: lizzie <[email protected] [email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4146
Reviewed-by: CamilleLaVey <[email protected] [email protected]
2026-07-02 19:24:07 +02:00
lizzie and CamilleLaVey
2068b5d452
[vk] Clamp dynamic descriptors based on device limits ( #4115 )
...
Should fix this specific crash
```
* thread #82 , name = 'GPU', stop reason = Exception 0xc0000005 encountered at address 0x7ff7e5193e89: Access violation reading location 0x00000098
* frame #0 : 0x00007ff7e5193e89 eden.exe`std::unique_ptr<Vulkan::Scheduler::CommandChunk,std::default_delete<Vulkan::Scheduler::CommandChunk> >::operator->(this=<unavailable>) at memory:3453 [inlined]
frame #1 : 0x00007ff7e5193e81 eden.exe`void Vulkan::Scheduler::DispatchWork(this=0x0000000000000000) at vk_scheduler.cpp:146
frame #2 : 0x00007ff7e5193d8f eden.exe`void Vulkan::Scheduler::WaitWorker(this=<unavailable>) at vk_scheduler.cpp:133
frame #3 : 0x00007ff7e54f472e eden.exe`void Vulkan::UpdateDescriptorQueue::Acquire(this=0x0000026c77cfb4b8) at vk_update_descriptor.cpp:41
frame #4 : 0x00007ff7e5537a43 eden.exe`void Vulkan::ASTCDecoderPass::Assemble(this=0x0000026c794fba10, image=0x0000026cfb794850, map=0x00000025e28fcb30, swizzles=<unavailable>) at vk_compute_pass.cpp:603
frame #5 : 0x00007ff7e55043e1 eden.exe`void Vulkan::TextureCacheRuntime::AccelerateImageUpload(this=<unavailable>, image=0x0000026cfb794850, map=0x00000025e28fcb30, swizzles=size=10, z_start=0, z_count=0) at vk_texture_cache.cpp:2482
frame #6 : 0x00007ff7e5516592 eden.exe`void VideoCommon::TextureCache<struct Vulkan::TextureCacheParams>::UploadImageContents<struct Vulkan::StagingBufferRef>(this=<unavailable>, image=0x0000026cfb794850, staging=0x00000025e28fcb30) at texture_cache.h:1147
frame #7 : 0x00007ff7e551523d eden.exe`void VideoCommon::TextureCache<struct Vulkan::TextureCacheParams>::RefreshContents(this=0x0000026c794fd800, image=0x0000026cfb794850, image_id=(index = 3801072224)) at texture_cache.h:1133
frame #8 : 0x00007ff7e5517b50 eden.exe`struct Common::SlotId VideoCommon::TextureCache<struct Vulkan::TextureCacheParams>::JoinImages(this=0x0000026c794fd800, info=<unavailable>, gpu_addr=25374426112, cpu_addr=2254181376) at texture_cache.h:1644
frame #9 : 0x00007ff7e5516ff6 eden.exe`struct Common::SlotId VideoCommon::TextureCache<struct Vulkan::TextureCacheParams>::InsertImage(this=0x0000026c794fd800, info=0x00000025e28fd270, gpu_addr=25374426112, options=0x0) at texture_cache.h:1513
frame #10 : 0x00007ff7e5516a60 eden.exe`struct Common::SlotId VideoCommon::TextureCache<struct Vulkan::TextureCacheParams>::FindOrInsertImage(this=0x0000026c794fd800, info=0x00000025e28fd270, gpu_addr=25374426112, options=0x0) at texture_cache.h:1194
frame #11 : 0x00007ff7e5515a13 eden.exe`struct Common::SlotId VideoCommon::TextureCache<struct Vulkan::TextureCacheParams>::CreateImageView(this=0x0000026c794fd800, config=0x00000025e28fd370) at texture_cache.h:1173
frame #12 : 0x00007ff7e550cd64 eden.exe`struct Common::SlotId VideoCommon::TextureCache<struct Vulkan::TextureCacheParams>::VisitImageView(this=0x0000026c794fd800, index=4586, compute=<unavailable>) at texture_cache.h:554
frame #13 : 0x00007ff7e550d181 eden.exe`void VideoCommon::TextureCache<struct Vulkan::TextureCacheParams>::FillImageViews(this=0x0000026c794fd800, views=size=5, compute=<unavailable>, blacklist=<unavailable>) at texture_cache.h:227
frame #14 : 0x00007ff7e58896e4 eden.exe`Vulkan::GraphicsPipeline::ConfigureImpl<Vulkan::(anonymous namespace)::SimpleStorageSpec>(this=0x0000026f865c1a60, is_indexed=<unavailable>) at vk_graphics_pipeline.cpp:415
frame #15 : 0x00007ff7e5889479 eden.exe`<lambda_1>::operator(pl=<unavailable>, is_indexed=<unavailable>) at vk_graphics_pipeline.h:123 [inlined]
frame #16 : 0x00007ff7e5889474 eden.exe`<lambda_1>::__invoke(pl=<unavailable>, is_indexed=<unavailable>) at vk_graphics_pipeline.h:123
frame #17 : 0x00007ff7e519d2a8 eden.exe`Vulkan::GraphicsPipeline::Configure(this=0x0000026f865c1a60, is_indexed=<unavailable>) at vk_graphics_pipeline.h:105 [inlined]
frame #18 : 0x00007ff7e519d29d eden.exe`Vulkan::RasterizerVulkan::PrepareDraw<`lambda at D:\a\g\g\eden-source\src\video_core\renderer_vulkan\vk_rasterizer.cpp:256:29'>(this=0x0000026c764f9368, is_indexed=<unavailable>, draw_func=0x00000025e28fdb80) at vk_rasterizer.cpp:244
frame #19 : 0x00007ff7e519d1db eden.exe`void Vulkan::RasterizerVulkan::Draw(this=<unavailable>, is_indexed=<unavailable>, instance_count=<unavailable>) at vk_rasterizer.cpp:256
frame #20 : 0x00007ff7e50d9025 eden.exe`void Tegra::HLE_DrawIndexedIndirect::Fallback(this=0x0000026f2af85118, maxwell3d=0x0000026ccbf9eb00, parameters=size=6) at macro.cpp:178
frame #21 : 0x00007ff7e50d8f21 eden.exe`void Tegra::HLE_DrawIndexedIndirect::Execute(this=0x0000026f2af85118, maxwell3d=0x0000026ccbf9eb00, parameters=size=6) at macro.cpp:129
frame #22 : 0x00007ff7e50db607 eden.exe`Tegra::MacroEngine::Execute::<lambda_0>::operator(this=0x00000025e28fde70, acm= Active Type = Tegra::HLE_DrawIndexedIndirect ) at macro.cpp:1362
frame #23 : 0x00007ff7e50dada0 eden.exe`void Tegra::MacroEngine::Execute(this=0x0000026ccbfaa020, maxwell3d=0x0000026ccbf9eb00, method=418, parameters=<unavailable>) at macro.cpp:1392
frame #24 : 0x00007ff7e4ef062b eden.exe`void Tegra::Engines::Maxwell3D::CallMacroMethod(this=0x0000026ccbf9eb00, method=<unavailable>, parameters=<unavailable>) at maxwell_3d.cpp:390
frame #25 : 0x00007ff7e4ef04be eden.exe`void Tegra::Engines::Maxwell3D::ProcessMacro(this=0x0000026ccbf9eb00, method=<unavailable>, base_start=<unavailable>, amount=5, is_last_call=<unavailable>) at maxwell_3d.cpp:223
frame #26 : 0x00007ff7e4ef1673 eden.exe`void Tegra::Engines::Maxwell3D::CallMultiMethod(this=<unavailable>, method=<unavailable>, base_start=0x000001ea398e22f4, amount=<unavailable>, methods_pending=5) at maxwell_3d.cpp:419
frame #27 : 0x00007ff7e4ef535a eden.exe`void Tegra::DmaPusher::CallMultiMethod(this=<unavailable>, base_start=0x000001ea398e22f4, num_methods=<unavailable>) const at dma_pusher.cpp:201
frame #28 : 0x00007ff7e4ef5023 eden.exe`void Tegra::DmaPusher::ProcessCommands(this=0x0000026ccbfba698, commands=size=36) at dma_pusher.cpp:120
frame #29 : 0x00007ff7e4ef4ced eden.exe`bool Tegra::DmaPusher::Step(this=0x0000026ccbfba698) at dma_pusher.cpp:88
frame #30 : 0x00007ff7e4ef49f8 eden.exe`void Tegra::DmaPusher::DispatchCalls(this=0x0000026ccbfba698) at dma_pusher.cpp:40
frame #31 : 0x00007ff7e4ede797 eden.exe`void Tegra::Control::Scheduler::Push(this=<unavailable>, channel=-493895072, entries=0x00000025e28fe2e0) at scheduler.cpp:31
frame #32 : 0x00007ff7e4eedc7b eden.exe`VideoCommon::GPUThread::ThreadManager::StartThread::<lambda_0>::operator(this=<unavailable>, stop_token=stop_token @ 0x00000025e28ffb40) at gpu_thread.cpp:42 [inlined]
frame #33 : 0x00007ff7e4eedae8 eden.exe`std::invoke(_Obj=<unavailable>, _Arg1=0x0000026ccb3edef0) at type_traits:1680 [inlined]
frame #34 : 0x00007ff7e4eedac1 eden.exe`std::thread::_Invoke<std::tuple<`lambda at D:\a\g\g\eden-source\src\video_core\gpu_thread.cpp:29:27',std::stop_token>,0,1>(_RawVals=0x0000026ccb3edef0) at thread:60
frame #35 : 0x00007ff8e87a37b0 ucrtbase.dll`wcsrchr + 336
```
Signed-off-by: lizzie <[email protected] [email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4115
Reviewed-by: MaranBr <[email protected] [email protected]
2026-06-30 04:33:30 +02:00
lizzie
1b482fa99b
[hle] remove parent object reference data on Request/Response builders, pass by argument ( #3774 )
...
anyways this should remove a bunch of redundant code/stack usage for response builders (ahem, msvc)
SHOULD help games that use IPC heavily like PKZA and whatnot
biblical levels of performance greed
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/3774
Reviewed-by: CamilleLaVey <[email protected] [email protected]
2026-06-29 08:11:12 +02:00
lizzie
09c583506b
[tests] Require backing base pointer to be nonnull for HostMemory tests ( #4138 )
...
A basic requirement, probably more helpful than outright crashing in the middle of a test.
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4138
Reviewed-by: MaranBr <[email protected] [email protected]
2026-06-28 08:01:41 +02:00
lizzie
894add43f3
[vk] fix PR5R black screen on qcom driver ( #4120 )
...
Different approach proposed by gido.
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4120
Reviewed-by: CamilleLaVey <[email protected]
2026-06-28 04:29:28 +02:00
Lizzie
d142b5dd6a
[android] Add Enable GPU Buffer Readback option to Android ( #4132 )
...
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4132
Reviewed-by: MaranBr <[email protected] [email protected]
2026-06-28 03:37:23 +02:00
lizzie
d8a8169eb2
[hle/bsd] do not use rust-result wannabe Expected in functions ( #4075 )
...
rust has Result<T,E> but we don't really need that in c++, also the header just sucks, objectively
Signed-off-by: lizzie [email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4075
Reviewed-by: CamilleLaVey <[email protected] [email protected]
2026-06-27 08:50:24 +02:00
lizzie
81c6e56713
[core/am] ban y2k domain to make Civ7 boot web-appletless ( #3868 )
...
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/3868
Reviewed-by: Maufeat <[email protected] [email protected] [email protected]
2026-06-27 08:46:18 +02:00
lizzie
6bdb03d8ac
[common/virtual_buffer] Fix Windows on Snapdragon 7C realizing virtual pages before they're needed ( #4128 )
...
This should fix Windows devices with low RAM like 4GB, or anything lower than 8GB.
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4128
Reviewed-by: Maufeat <[email protected] [email protected]
2026-06-25 00:11:36 +02:00
lizzie and maufeat
3aa0d46259
[video_core, hle] remove redundant parent references in system structs ( #3908 )
...
reworked a bit to remove references of parent objects and instead pass as arguments to methods to prevent useless reloads
Signed-off-by: lizzie <[email protected] [email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/3908
Reviewed-by: Maufeat <[email protected] [email protected]
2026-06-23 06:31:25 +02:00
lizzie
f8facda35f
[vk] Prevent OOM due to increased staging buffer on *nix ( #4116 )
...
*nix drivers for NVIDIA doesn't seem to like the increased size.
Windows is fine with it however.
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4116
Reviewed-by: MaranBr <[email protected]
2026-06-23 01:48:11 +02:00
lizzie
97a8470b12
[android] fix 'clear per game shader cache' not accounting for new cache ( #4109 )
...
fixes android which I didn't account for initially
oops!
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4109
Reviewed-by: MaranBr <[email protected] [email protected]
2026-06-19 23:42:16 +02:00
lizzie
c8c61a12c3
[dynarmic, MacroHLE] Fix crashes on W^X systems ( #4090 )
...
should fix crashes on:
- NetBSD
- SELinux
- OpenBSD
- other W^X systems
- some person trying to be funny with W^X on their system even if they dont have to
perf impact should be minimal
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4090
Reviewed-by: MaranBr <[email protected] [email protected]
2026-06-15 22:06:14 +02:00
lizzie
b05463ee19
[fs] use XDG_CACHE_HOME for shader caches ( #4093 )
...
makes it so the shader cache goes properly in `XDG_CACHE_HOME`.
SOME people have it set to point to `/tmp` AND as a ramdisk, if they can do that they probably would want their shader caches to be there as well and wouldnt mind the extra hit from invalidations on reboot.
afterall, its a cache, not some holy data that needs to be kept at all costs.
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4093
Reviewed-by: MaranBr <[email protected] [email protected]
2026-06-15 22:05:53 +02:00
lizzie
561adac0af
[common] fallback to VirtualBuffer if we can't use file mappings ( #4005 )
...
fixes:
- windows 8.1
- windows 7
- managarm
- openorbis
Signed-off-by: lizzie [email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4005
Reviewed-by: MaranBr <[email protected] [email protected]
2026-06-15 22:05:42 +02:00
lizzie
62ef8b15fd
[video_core] correct not-quite-correct PTE_kind enumeration ( #4077 )
...
should now be more align with actual values/enums :)
trivial change
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4077
Reviewed-by: MaranBr <[email protected] [email protected]
2026-06-15 22:05:18 +02:00
lizzie
8e9513cb5f
[service/ro] Fix too many plugin.nro not being loaded for SSBU ( #3982 )
...
Good fix or absolute trash?
For me it seems like an OK balance, better would be fully dynamic; but I believe 256 is a reasonable limit?
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/3982
Reviewed-by: MaranBr <[email protected] [email protected]
2026-06-15 21:59:53 +02:00
lizzie
950e0f82fb
[hle/sm] implement sm:AtmosphereHasService ( #3771 )
...
should make a few more homebrew boot :)
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/3771
Reviewed-by: MaranBr <[email protected] [email protected]
2026-06-15 21:56:22 +02:00
lizzie
74a6607f8e
[fs] do not early abort on IterateDirEntries{Recursively} ( #4100 )
...
should fix some issues with some NAS setups
where people have their games on a NAS and they
try to access it but for some reason some file
just doesnt load, instead of aborting early we continue
for the rest of the files in the directory
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4100
Reviewed-by: Shinmegumi <[email protected] [email protected]
2026-06-15 21:31:20 +02:00
lizzie
60e1032771
[qt] fix various crashes due to invalid/corrupted/outdated settings ( #4070 )
...
lots of "out of index" errors :)
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4070
Reviewed-by: crueter <[email protected] [email protected]
2026-06-14 20:48:24 +02:00
lizzie
4edb1ac6c5
[common/fs] create XDG_DATA_{HOME,CACHE,CONFIG}_HOME if we are the first application to ever be ran or they dont exist for a reason ( #4087 )
...
samu will be happy
basically this handles the edge case where either:
a) eden is the first application ever ran (i.e no config dirs made yet)
b) user didnt have them
c) user is trying to run on a sandbox appimage or whatever bs
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4087
Reviewed-by: crueter <[email protected] [email protected]
2026-06-12 23:55:09 +02:00
lizzie
3875093c70
[hle] Fixes for nxident, nxmp and nxplay, remove hbl.nsp workarounds ( #3996 )
...
adds `gpio` and `i2c` services
implements `IApplicationFunctions::SetMediaPlaybackStateForApplicatio`
stubs `IBtmSystemCore::GetDiscoveredAudioDevice`
implements `nvhost_ctrl_gpu::PmuGetGpuLoad` IOCTL (0x20)
implements `PSM::GetBatteryAgePercentage`, `PSM::GetBatteryVoltageState` and `PSM::GetBatteryChargeInfoFields`
implements `ISystemSettingsServer::GetConsoleInformationUploadFlag`, `ISystemSettingsServer::SetConsoleInformationUploadFlag`, `ISystemSettingsServer::GetAutomaticApplicationDownloadFlag`, `ISystemSettingsServer::SetAutomaticApplicationDownloadFlag`, `&ISystemSettingsServer::GetUsb30EnableFlag`, `ISystemSettingsServer::SetUsb30EnableFlag`
removes `hbl.nsp` specific workarounds
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/3996
Reviewed-by: MaranBr <[email protected] [email protected]
2026-06-12 23:48:24 +02:00
lizzie
5219b9f3d2
[deps] update sirit 1.0.4 -> 1.0.5 ( #4079 )
...
should fix CI sourcepack issues
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4079
Reviewed-by: Maufeat <[email protected]
2026-06-10 20:52:35 +02:00
lizzie
5ba3ae32dc
[hle/sockets] fix crash when socket() isn't initialized but send()/recv() are called ( #3729 )
...
the correct behaviour would be for the hle service NOT to crash
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/3729
Reviewed-by: Maufeat <[email protected] [email protected]
2026-06-06 03:54:55 +02:00
lizzie
a4e9b08fe7
[docs] clang-cl with MSVC, misc docs updates ( #4034 )
...
- vtable bounce is all gone
- factual corrections to HosKernel.md
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4034
Reviewed-by: crueter <[email protected] [email protected]
2026-06-04 19:39:21 +02:00
lizzie
ce9c7c196d
[cmake] fix OpenSSL not using <openssl/cert.h> when applicable because it tries to use the system one instead of being explicitly linked ( #4053 )
...
should fix hiccups with self-built OpenSSL
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4053
Reviewed-by: crueter <[email protected] [email protected]
2026-06-04 19:39:09 +02:00
lizzie
89199f4d27
[*] basic in-house cpp linting ( #4039 )
...
- add `#pragma once` to remainder files
- "correcter" defines (ANDROID), see https://groups.google.com/g/android-ndk/c/cf9_f1SLXls
- extra miscelly fixups
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4039
Reviewed-by: MaranBr <[email protected] [email protected]
2026-06-04 05:49:07 +02:00
lizzie
978d9d935d
[vk/vma] force ANV to have HOST_CACHED stream buffers ( #3792 )
...
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/3792
Reviewed-by: MaranBr <[email protected] [email protected]
2026-06-04 05:48:41 +02:00
lizzie
ad9af25027
[dynarmic] fix pre-SSE4.1 having errors on CMHI/CMLO, fix extra nuisances and add INTERP testcase ( #4025 )
...
does a bit of code dedup
fixes pre-SSE4.1 having horrific CMHI/CMLO
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4025
Reviewed-by: crueter <[email protected] [email protected]
2026-06-03 22:53:21 +02:00
lizzie
f729dbb3c3
[common] use abi::__cxa_demangle for demangling using the system's glibcxx/libc++ ( #3894 )
...
most stdlibc++ already provide this functionality out of the box, very consistently and well implemented (usually)
my main irk is that the llvm itanium demangle is totally unescesary when there is a perfectly stable, tested and well documented equivalent functionality in the standard stdc++ provided in most UNIX oses
its mostly to reduce binary size by a very thin margin, but he stdc++ is more than capable of doing he same behaviour we use a dpeendency for
for mingw or such howeger,, demangling becomies trickier so we have to exclude windows entirely because well windows likes to do things differently dont they
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/3894
Reviewed-by: crueter <[email protected] [email protected]
2026-06-03 22:53:09 +02:00
lizzie
5027aecf77
[vk] handle mali/adreno5xx driver bug returning VK_INCOMPLETE on graphics pipeline creation ( #3383 )
...
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/3383
Reviewed-by: crueter <[email protected] [email protected]
2026-06-02 21:57:23 +02:00
lizzie
8fac95dcc0
[vk] Fix regressions introduced by #3997 w.r.t to marked stages for pipeline barriers ( #4037 )
...
evil barriers :)
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4037
Reviewed-by: MaranBr <[email protected] [email protected]
2026-06-02 01:28:39 +02:00
lizzie
5f4a286046
[dynarmic] cleanup duplicate code and reimpls of std::* bit stuff ( #4017 )
...
A bit of a minor cleanup
- std::rotr instead of mcl::bit::rotate_right
- std::rotl likewise
- std::popcount instaed of "count ones"
- use ConvertRoundingModeToX64Immediate where appropiate
- std integral
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4017
Reviewed-by: MaranBr <[email protected] [email protected]
2026-05-31 04:18:12 +02:00
lizzie
23bb909bc9
[audio_core] fix OOB copy when silencing channel on shutdown ( #3969 )
...
when shutting down the emulator will silence any remaining audio from the output buffer
however this is for some reason stored in an array instead of being a simple memset
additionally, said array can be small enough (`frame_size_bytes > silence.size()`) to cause a funky noise to play at the end
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/3969
Reviewed-by: MaranBr <[email protected] [email protected]
2026-05-31 02:38:26 +02:00
lizzie
e94ac63a5e
[common/thread] fix MSVC build error with _rdstc ( #4029 )
...
fixes issue reported by @bruno
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4029
Reviewed-by: MaranBr <[email protected] [email protected]
2026-05-31 02:32:21 +02:00
lizzie
116377f6d9
[vk] fix oversight with #3874 with invalid image ids ( #4026 )
...
oopsie, forgot we had a GC
fixes SSBU
Signed-off-by: lizzie <[email protected] https://git.eden-emu.dev/eden-emu/eden/pulls/4026
Reviewed-by: MaranBr <[email protected] [email protected]
2026-05-30 21:59:18 +02:00
lizzie
