Files
ppsspp/Core/HLE/sceKernelSemaphore.cpp
Henrik RydgårdandClaude Opus 5.5 80938529a9 Kernel waits: Share waiter ordering and clearing between objects
Priority-ordered waiting lists were sorted with a comparator wrapper per
object (msgpipe, fpl, vpl), or searched with a copy of the same function
(mutex, mbx). HLEKernel::SortWaitingThreadsByPriority() and
FindBestPriorityWaiter() now do both for any waiting list, of thread ids
or of structs with a threadID.

HLEKernel::ClearWaitingThreads() replaces the identical cancel/delete
loops in semaphores, event flags, fpl and vpl.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-30 09:06:30 -06:00

359 lines
12 KiB
C++

// Copyright (c) 2012- PPSSPP Project.
// This program is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, version 2.0 or later versions.
// This program is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License 2.0 for more details.
// A copy of the GPL 2.0 should have been included with the program.
// If not, see http://www.gnu.org/licenses/
// Official git repository and contact information can be found at
// https://github.com/hrydgard/ppsspp and http://www.ppsspp.org/.
#include <algorithm>
#include "Common/Serialize/Serializer.h"
#include "Common/Serialize/SerializeFuncs.h"
#include "Common/Serialize/SerializeMap.h"
#include "Core/HLE/HLE.h"
#include "Core/HLE/ErrorCodes.h"
#include "Core/MIPS/MIPS.h"
#include "Core/CoreTiming.h"
#include "Core/MemMapHelpers.h"
#include "Core/Reporting.h"
#include "Core/HLE/sceKernel.h"
#include "Core/HLE/sceKernelThread.h"
#include "Core/HLE/sceKernelSemaphore.h"
#include "Core/HLE/KernelWaitHelpers.h"
#include "Core/HLE/FunctionWrappers.h"
#define PSP_SEMA_ATTR_FIFO 0
#define PSP_SEMA_ATTR_PRIORITY 0x100
/** Current state of a semaphore.
* @see sceKernelReferSemaStatus.
*/
// NativeSemaphore/PSPSemaphore itself now live in sceKernelSemaphore.h - see the comment on the
// class there for why.
void PSPSemaphore::DoState(PointerWrap &p) {
auto s = p.Section("Semaphore", 1);
if (!s)
return;
Do(p, ns);
SceUID dv = 0;
Do(p, waitingThreads, dv);
Do(p, pausedWaits);
}
void __KernelSemaBeginCallback(SceUID threadID, SceUID prevCallbackId);
void __KernelSemaEndCallback(SceUID threadID, SceUID prevCallbackId);
void __KernelSemaInit()
{
__KernelRegisterWaitTypeFuncs(WAITTYPE_SEMA, __KernelSemaBeginCallback, __KernelSemaEndCallback, __KernelSemaTimeout);
}
void __KernelSemaDoState(PointerWrap &p)
{
auto s = p.Section("sceKernelSema", 1, 2);
if (!s)
return;
if (s < 2) {
int oldTimeoutEvent = -1;
Do(p, oldTimeoutEvent);
__KernelRestoreOldWaitTimeoutEvent(oldTimeoutEvent, "SemaphoreTimeout");
}
}
KernelObject *__KernelSemaphoreObject()
{
return new PSPSemaphore;
}
// Returns whether the thread should be removed.
static bool __KernelUnlockSemaForThread(PSPSemaphore *s, SceUID threadID, u32 &error, int result, bool &wokeThreads) {
if (!HLEKernel::VerifyWait(threadID, WAITTYPE_SEMA, s->GetUID()))
return true;
// If result is an error code, we're just letting it go.
if (result == 0)
{
int wVal = (int) __KernelGetWaitValue(threadID, error);
if (wVal > s->ns.currentCount)
return false;
s->ns.currentCount -= wVal;
}
u32 timeoutPtr = __KernelGetWaitTimeoutPtr(threadID, error);
HLEKernel::WriteRemainingTimeout(threadID, timeoutPtr);
__KernelResumeThreadFromWait(threadID, result);
wokeThreads = true;
return true;
}
void __KernelSemaBeginCallback(SceUID threadID, SceUID prevCallbackId)
{
auto result = HLEKernel::WaitBeginCallback<PSPSemaphore, WAITTYPE_SEMA, SceUID>(threadID, prevCallbackId);
if (result == HLEKernel::WAIT_CB_SUCCESS)
DEBUG_LOG(Log::sceKernel, "sceKernelWaitSemaCB: Suspending sema wait for callback");
else
WARN_LOG_REPORT(Log::sceKernel, "sceKernelWaitSemaCB: beginning callback with bad wait id?");
}
void __KernelSemaEndCallback(SceUID threadID, SceUID prevCallbackId)
{
auto result = HLEKernel::WaitEndCallback<PSPSemaphore, WAITTYPE_SEMA, SceUID>(threadID, prevCallbackId, __KernelUnlockSemaForThread);
if (result == HLEKernel::WAIT_CB_RESUMED_WAIT)
DEBUG_LOG(Log::sceKernel, "sceKernelWaitSemaCB: Resuming sema wait for callback");
}
// Resume all waiting threads (for delete / cancel.)
// Returns true if it woke any threads.
int sceKernelCancelSema(SceUID id, int newCount, u32 numWaitThreadsPtr)
{
u32 error;
PSPSemaphore *s = kernelObjects.Get<PSPSemaphore>(id, error);
if (!s) {
return hleLogError(Log::sceKernel, error, "bad sema id");
} else {
if (newCount > s->ns.maxCount) {
return hleLogError(Log::sceKernel, SCE_KERNEL_ERROR_ILLEGAL_COUNT);
}
DEBUG_LOG(Log::sceKernel, "sceKernelCancelSema(%i, %i, %08x)", id, newCount, numWaitThreadsPtr);
s->ns.numWaitThreads = (int) s->waitingThreads.size();
if (Memory::IsValidAddress(numWaitThreadsPtr))
Memory::WriteOrException_U32(s->ns.numWaitThreads, numWaitThreadsPtr);
if (newCount < 0)
s->ns.currentCount = s->ns.initCount;
else
s->ns.currentCount = newCount;
if (HLEKernel::ClearWaitingThreads(s, SCE_KERNEL_ERROR_WAIT_CANCEL, __KernelUnlockSemaForThread))
hleReSchedule("semaphore canceled");
return hleNoLog(0);
}
}
int sceKernelCreateSema(const char* name, u32 attr, int initVal, int maxVal, u32 optionPtr) {
if (!name) {
// This is strangely quite common! Some shared library must be doing this.
return hleLogWarning(Log::sceKernel, SCE_KERNEL_ERROR_ERROR, "invalid name");
}
if (attr >= 0x200) {
return hleLogWarning(Log::sceKernel, SCE_KERNEL_ERROR_ILLEGAL_ATTR, "invalid attr parameter %08x", attr);
}
PSPSemaphore *s = new PSPSemaphore();
SceUID id = kernelObjects.Create(s);
s->ns.size = sizeof(NativeSemaphore);
strncpy(s->ns.name, name, KERNELOBJECT_MAX_NAME_LENGTH);
s->ns.name[KERNELOBJECT_MAX_NAME_LENGTH] = 0;
s->ns.attr = attr;
s->ns.initCount = initVal;
s->ns.currentCount = s->ns.initCount;
s->ns.maxCount = maxVal;
s->ns.numWaitThreads = 0;
if ((attr & ~PSP_SEMA_ATTR_PRIORITY) != 0) {
WARN_LOG_REPORT(Log::sceKernel, "sceKernelCreateSema(%s) unsupported attr parameter: %08x", name, attr);
}
// Many games pass garbage into optionPtr, it doesn't have any options.
// TODO: Presumably that means that this function simply doesn't have an option parameter?
if (optionPtr != 0) {
if (!Memory::IsValidRange(optionPtr, 4))
return hleLogWarning(Log::sceKernel, id, "invalid options parameter");
else if (Memory::ReadUnchecked_U32(optionPtr) > 4)
return hleLogDebug(Log::sceKernel, id, "invalid options parameter size");
}
return hleLogDebug(Log::sceKernel, id);
}
int sceKernelDeleteSema(SceUID id) {
u32 error;
PSPSemaphore *s = kernelObjects.Get<PSPSemaphore>(id, error);
if (!s) {
return hleLogError(Log::sceKernel, error, "bad sema id");
} else {
DEBUG_LOG(Log::sceKernel, "sceKernelDeleteSema(%i)", id);
bool wokeThreads = HLEKernel::ClearWaitingThreads(s, SCE_KERNEL_ERROR_WAIT_DELETE, __KernelUnlockSemaForThread);
if (wokeThreads)
hleReSchedule("semaphore deleted");
return hleNoLog(kernelObjects.Destroy<PSPSemaphore>(id));
}
}
int sceKernelReferSemaStatus(SceUID id, u32 infoPtr) {
u32 error;
PSPSemaphore *s = kernelObjects.Get<PSPSemaphore>(id, error);
if (!s) {
return hleLogError(Log::sceKernel, error, "bad sema id");
} else {
auto info = PSPPointer<NativeSemaphore>::Create(infoPtr);
if (!info.IsValid())
return hleLogWarning(Log::sceKernel, -1, "invalid pointer");
HLEKernel::CleanupWaitingThreads(WAITTYPE_SEMA, id, s->waitingThreads);
s->ns.numWaitThreads = (int) s->waitingThreads.size();
if (info->size != 0) {
*info = s->ns;
info.NotifyWrite("SemaStatus");
}
return hleLogDebug(Log::sceKernel, 0);
}
}
int sceKernelSignalSema(SceUID id, int signal) {
u32 error;
PSPSemaphore *s = kernelObjects.Get<PSPSemaphore>(id, error);
if (!s) {
if (id == 0 && error == SCE_KERNEL_ERROR_UNKNOWN_SEMID) {
// See #20111. Prevents logspam.
return hleLogDebug(Log::sceKernel, error, "bad sema id");
} else {
return hleLogError(Log::sceKernel, error, "bad sema id");
}
} else {
// Done in 64-bit so a huge signal value can't overflow its way past the check.
if ((s64)s->ns.currentCount + signal - (s64)s->waitingThreads.size() > s->ns.maxCount) {
return hleLogDebug(Log::sceKernel, SCE_KERNEL_ERROR_SEMA_OVF, "overflow at %d", s->ns.currentCount);
}
int oldval = s->ns.currentCount;
s->ns.currentCount += signal;
if ((s->ns.attr & PSP_SEMA_ATTR_PRIORITY) != 0)
HLEKernel::SortWaitingThreadsByPriority(s->waitingThreads);
bool wokeThreads = false;
retry:
for (auto iter = s->waitingThreads.begin(), end = s->waitingThreads.end(); iter != end; ++iter) {
if (__KernelUnlockSemaForThread(s, *iter, error, 0, wokeThreads)) {
s->waitingThreads.erase(iter);
goto retry;
}
}
if (wokeThreads)
hleReSchedule("semaphore signaled");
hleEatCycles(900);
return hleLogDebug(Log::sceKernel, 0, "sceKernelSignalSema(%i, %i) (count: %i -> %i)", id, signal, oldval, s->ns.currentCount);
}
}
void __KernelSemaTimeout(u64 userdata, int cycleslate) {
SceUID threadID = (SceUID)userdata;
u32 error;
SceUID uid = __KernelGetWaitID(threadID, WAITTYPE_SEMA, error);
HLEKernel::WaitExecTimeout<PSPSemaphore, WAITTYPE_SEMA>(threadID);
// If in FIFO mode, that may have cleared another thread to wake up.
PSPSemaphore *s = kernelObjects.Get<PSPSemaphore>(uid, error);
if (s && (s->ns.attr & PSP_SEMA_ATTR_PRIORITY) == PSP_SEMA_ATTR_FIFO) {
bool wokeThreads = false;
std::vector<SceUID>::iterator iter = s->waitingThreads.begin();
// Unlock every waiting thread until the first that must still wait.
while (iter != s->waitingThreads.end() && __KernelUnlockSemaForThread(s, *iter, error, 0, wokeThreads)) {
s->waitingThreads.erase(iter);
iter = s->waitingThreads.begin();
}
}
}
static int __KernelWaitSema(SceUID id, int wantedCount, u32 timeoutPtr, bool processCallbacks) {
hleEatCycles(900);
if (wantedCount <= 0)
return SCE_KERNEL_ERROR_ILLEGAL_COUNT;
hleEatCycles(500);
u32 error;
PSPSemaphore *s = kernelObjects.Get<PSPSemaphore>(id, error);
if (!s) {
return error;
} else {
if (wantedCount > s->ns.maxCount)
return SCE_KERNEL_ERROR_ILLEGAL_COUNT;
// If there are any callbacks, we always wait, and wake after the callbacks.
bool hasCallbacks = processCallbacks && __KernelCurHasReadyCallbacks();
if (s->ns.currentCount >= wantedCount && s->waitingThreads.size() == 0 && !hasCallbacks) {
s->ns.currentCount -= wantedCount;
} else {
if (!hasCallbacks && __KernelWaitTimesOutAtOnce(timeoutPtr))
return SCE_KERNEL_ERROR_WAIT_TIMEOUT;
SceUID threadID = __KernelGetCurThread();
// May be in a tight loop timing out (where we don't remove from waitingThreads yet), don't want to add duplicates.
if (std::find(s->waitingThreads.begin(), s->waitingThreads.end(), threadID) == s->waitingThreads.end())
s->waitingThreads.push_back(threadID);
__KernelWaitCurThreadWithTimeout(WAITTYPE_SEMA, id, wantedCount, timeoutPtr, processCallbacks, "sema waited");
}
return 0;
}
}
int sceKernelWaitSema(SceUID id, int wantedCount, u32 timeoutPtr) {
int result = __KernelWaitSema(id, wantedCount, timeoutPtr, false);
if (id == 0 && result == SCE_KERNEL_ERROR_UNKNOWN_SEMID) {
// See #20111. Prevents logspam.
return hleLogDebug(Log::sceKernel, result, "bad sema id");
}
return hleLogDebugOrError(Log::sceKernel, result);
}
int sceKernelWaitSemaCB(SceUID id, int wantedCount, u32 timeoutPtr) {
int result = __KernelWaitSema(id, wantedCount, timeoutPtr, true);
if (id == 0 && result == SCE_KERNEL_ERROR_UNKNOWN_SEMID) {
// See #20111. Prevents logspam.
return hleLogDebug(Log::sceKernel, result, "bad sema id");
}
return hleLogDebugOrError(Log::sceKernel, result);
}
// Should be same as WaitSema but without the wait, instead returning SCE_KERNEL_ERROR_SEMA_ZERO
int sceKernelPollSema(SceUID id, int wantedCount) {
if (wantedCount <= 0) {
return hleLogError(Log::sceKernel, SCE_KERNEL_ERROR_ILLEGAL_COUNT);
}
u32 error;
PSPSemaphore *s = kernelObjects.Get<PSPSemaphore>(id, error);
if (!s) {
return hleLogError(Log::sceKernel, error, "invalid semaphore");
}
if (s->ns.currentCount >= wantedCount && s->waitingThreads.size() == 0) {
s->ns.currentCount -= wantedCount;
return hleLogDebug(Log::sceKernel, 0);
} else {
// this is OK.
return hleLogDebug(Log::sceKernel, SCE_KERNEL_ERROR_SEMA_ZERO);
}
}