Mirror/ppsspp
1
0 Fork 0
mirror of https://github.com/hrydgard/ppsspp.git synced 2026-10-01 14:58:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Debugger: Remove double debug window updates.

Browse Source 
Core_EnableStepping() is already marking the debug windows for update,
there's no need to call SetDebugMode() again.
This commit is contained in:
Unknown W. Brackets committed 2021-12-12 11:24:03 -08:00
1 parent c57e5b081d
commit db2eddcf27
5 files changed
+1 -20
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

Core/Core.cpp
-4
View File
@@ -447,7 +447,6 @@ void Core_MemoryException(u32 address, u32 pc, MemoryExceptionType type) {
e.address = address;
e.pc = pc;
Core_EnableStepping(true, "memory.exception", address);
host->SetDebugMode(true);
}
}
@@ -469,7 +468,6 @@ void Core_MemoryExceptionInfo(u32 address, u32 pc, MemoryExceptionType type, std
e.address = address;
e.pc = pc;
Core_EnableStepping(true, "memory.exception", address);
host->SetDebugMode(true);
}
}
@@ -485,7 +483,6 @@ void Core_ExecException(u32 address, u32 pc, ExecExceptionType type) {
e.address = address;
e.pc = pc;
Core_EnableStepping(true, "cpu.exception", pc);
host->SetDebugMode(true);
}
void Core_Break() {
@@ -498,7 +495,6 @@ void Core_Break() {
if (!g_Config.bIgnoreBadMemAccess) {
Core_EnableStepping(true, "cpu.breakInstruction", currentMIPS->pc);
host->SetDebugMode(true);
}
}
Core/Debugger/Breakpoints.cpp
-4
View File
@@ -69,7 +69,6 @@ BreakAction MemCheck::Action(u32 addr, bool write, int size, u32 pc, const char
Log(addr, write, size, pc, reason);
if ((result & BREAK_ACTION_PAUSE) && coreState != CORE_POWERUP) {
Core_EnableStepping(true, "memory.breakpoint", start);
host->SetDebugMode(true);
}
return result;
@@ -125,8 +124,6 @@ void MemCheck::JitCleanup(bool changed)
CBreakPoints::SetSkipFirst(lastPC);
Core_EnableStepping(false);
}
else
host->SetDebugMode(true);
}
// Note: must lock while calling this.
@@ -368,7 +365,6 @@ BreakAction CBreakPoints::ExecBreakPoint(u32 addr) {
}
if ((info.result & BREAK_ACTION_PAUSE) && coreState != CORE_POWERUP) {
Core_EnableStepping(true, "cpu.breakpoint", info.addr);
host->SetDebugMode(true);
}
return info.result;
Core/HLE/HLE.cpp
-1
View File
@@ -364,7 +364,6 @@ bool hleExecuteDebugBreak(const HLEFunction &func)
}
Core_EnableStepping(true, "hle.step", latestSyscallPC);
host->SetDebugMode(true);
return true;
}
Core/MIPS/x86/CompBranch.cpp
+1 -1
View File
@@ -110,7 +110,7 @@ static void JitBranchLogMismatch(MIPSOpcode op, u32 pc)
char temp[256];
MIPSDisAsm(op, pc, temp, true);
ERROR_LOG(JIT, "Bad jump: %s - int:%08x jit:%08x", temp, currentMIPS->intBranchExit, currentMIPS->jitBranchExit);
host->SetDebugMode(true);
Core_EnableStepping(true, "jit.branchdebug", pc);
}
void Jit::BranchLog(MIPSOpcode op)
Windows/Debugger/Debugger_Disasm.cpp
-10
View File
@@ -286,7 +286,6 @@ void CDisasm::stepOver()
ptr->scrollStepping(breakpointAddress);
}
SetDebugMode(false, true);
CBreakPoints::AddBreakPoint(breakpointAddress,true);
Core_EnableStepping(false);
Sleep(1);
@@ -324,7 +323,6 @@ void CDisasm::stepOut()
CtrlDisAsmView *ptr = CtrlDisAsmView::getFrom(GetDlgItem(m_hDlg,IDC_DISASMVIEW));
ptr->setDontRedraw(true);
SetDebugMode(false, true);
CBreakPoints::AddBreakPoint(breakpointAddress,true);
Core_EnableStepping(false);
Sleep(1);
@@ -343,7 +341,6 @@ void CDisasm::runToLine()
lastTicks = CoreTiming::GetTicks();
ptr->setDontRedraw(true);
SetDebugMode(false, true);
CBreakPoints::AddBreakPoint(pos,true);
Core_EnableStepping(false);
}
@@ -420,7 +417,6 @@ BOOL CDisasm::DlgProc(UINT message, WPARAM wParam, LPARAM lParam)
bool isRunning = Core_IsActive();
if (isRunning)
{
SetDebugMode(true, false);
Core_EnableStepping(true, "cpu.breakpoint.add", 0);
Core_WaitInactive(200);
}
@@ -429,10 +425,7 @@ BOOL CDisasm::DlgProc(UINT message, WPARAM wParam, LPARAM lParam)
if (bpw.exec()) bpw.addBreakpoint();
if (isRunning)
{
SetDebugMode(false, false);
Core_EnableStepping(false);
}
keepStatusBarText = false;
}
break;
@@ -524,7 +517,6 @@ BOOL CDisasm::DlgProc(UINT message, WPARAM wParam, LPARAM lParam)
if (!Core_IsStepping()) // stop
{
ptr->setDontRedraw(false);
SetDebugMode(true, true);
Core_EnableStepping(true, "ui.break", 0);
Sleep(1); //let cpu catch up
ptr->gotoPC();
@@ -537,7 +529,6 @@ BOOL CDisasm::DlgProc(UINT message, WPARAM wParam, LPARAM lParam)
// If the current PC is on a breakpoint, the user doesn't want to do nothing.
CBreakPoints::SetSkipFirst(currentMIPS->pc);
SetDebugMode(false, true);
Core_EnableStepping(false);
}
}
@@ -565,7 +556,6 @@ BOOL CDisasm::DlgProc(UINT message, WPARAM wParam, LPARAM lParam)
CBreakPoints::SetSkipFirst(currentMIPS->pc);
hleDebugBreak();
SetDebugMode(false, true);
Core_EnableStepping(false);
}
break;