Merge pull request #22262 from NABN00B/stereo-settings

Show stereo shader options dynamically

Core/HLE/AtracCtx2.cpp

@@ -174,6 +174,7 @@ static int ComputeAtracStateAndInitSecondBuffer(SceAtracIdInfo *info, u32 readSi
 
 	if (bufferSize < (u32)info->fileDataEnd) {
 		if (info->streamDataByte < (s32)info->sampleSize * 2) {
+			// sampleSize * 3 would be more accurate, but we increase tolerance for GTA LCS custom music (#20692).
 			return SCE_ERROR_ATRAC_SIZE_TOO_SMALL;
 		}
 		loopEnd = info->loopEnd;

UI/DeveloperToolsScreen.cpp

@@ -576,17 +576,20 @@ void DeveloperToolsScreen::CreateGraphicsTab(UI::LinearLayout *list) {
 	if (multiViewSupported) {
 		list->Add(new ItemHeader(gr->T("Stereo rendering")));
 		list->Add(new CheckBox(&g_Config.bStereoRendering, gr->T("Stereo rendering")));
-		std::vector<std::string> stereoShaderNames;
 
 		ChoiceWithValueDisplay *stereoShaderChoice = list->Add(new ChoiceWithValueDisplay(&g_Config.sStereoToMonoShader, gr->T("Stereo display shader"), &PostShaderTranslateName));
 		stereoShaderChoice->SetEnabledFunc(enableStereo);
 		stereoShaderChoice->OnClick.Add([=](EventParams &e) {
 			auto gr = GetI18NCategory(I18NCat::GRAPHICS);
 			auto procScreen = new PostProcScreen(gr->T("Stereo display shader"), 0, true);
+			procScreen->OnChoice.Add([this](EventParams &) {
+				RecreateViews();
+			});
 			if (e.v)
 				procScreen->SetPopupOrigin(e.v);
 			screenManager()->push(procScreen);
 		});
+
 		const ShaderInfo *shaderInfo = GetPostShaderInfo(g_Config.sStereoToMonoShader);
 		if (shaderInfo) {
 			for (size_t i = 0; i < ARRAY_SIZE(shaderInfo->settings); ++i) {
@@ -660,8 +663,7 @@ void DeveloperToolsScreen::CreateTabs() {
 	AddTab("DumpFiles", dev->T("Dump files"), [this](UI::LinearLayout *parent) {
 		CreateDumpFileTab(parent);
 	});
-	// Need a better title string.
-	AddTab("HLE", dev->T("Disable HLE"), [this](UI::LinearLayout *parent) {
+	AddTab("HLE", dev->T("HLE"), [this](UI::LinearLayout *parent) {
 		CreateHLETab(parent);
 	});
 #if !PPSSPP_PLATFORM(ANDROID) && !PPSSPP_PLATFORM(IOS) && !PPSSPP_PLATFORM(SWITCH)