mirror of
https://github.com/hrydgard/ppsspp.git
synced 2026-10-01 14:58:14 +00:00
Github CI: Use pull_request_target instead of pull_request
The idea is that PRs should build on CI even if there are conflicts. This is useful for hotfix branches like v1.19.3-commits, where I cherry-pick PRs from master to produce a new release without including any risky recent changes. I'm testing it in that branch right now and it seems to work. I'm making this a separate PR before including in the main branch, so you guys can warn me in case this is a mistake somehow :) I showed my changes to ChatGPT and it suggested adding the permissions clause, not exactly sure why it's more needed now. Discussion here: https://github.com/orgs/community/discussions/26304
This commit is contained in:
1 parent
a90f772d1b
commit
c93f7d2152
2 files changed
+12
-4
No files matched your search
@@ -2,7 +2,7 @@ name: Generate Linux AppImage
|
||||
on:
|
||||
push:
|
||||
branches:
|
||||
- master
|
||||
- '**'
|
||||
# For testing.
|
||||
#- test_arch
|
||||
tags:
|
||||
@@ -12,7 +12,7 @@ on:
|
||||
- 'Tools/**'
|
||||
- '.{editorconfig,gitattributes,gitignore}'
|
||||
- 'appveyor.yml'
|
||||
pull_request:
|
||||
pull_request_target:
|
||||
branches:
|
||||
- master
|
||||
paths-ignore:
|
||||
@@ -26,6 +26,10 @@ env:
|
||||
#SDL_VIDEODRIVER: "dummy"
|
||||
#BUILD_CONFIGURATION: Release #RelWithDebInfo
|
||||
|
||||
permissions:
|
||||
contents: read
|
||||
pull-requests: read
|
||||
|
||||
jobs:
|
||||
build:
|
||||
name: build (${{ matrix.id }})
|
||||
|
||||
@@ -3,7 +3,7 @@ name: Build
|
||||
on:
|
||||
push:
|
||||
branches:
|
||||
- master
|
||||
- '**'
|
||||
# For testing.
|
||||
- actions
|
||||
tags:
|
||||
@@ -13,7 +13,7 @@ on:
|
||||
- 'Tools/**'
|
||||
- '.{editorconfig,gitattributes,gitignore}'
|
||||
- 'appveyor.yml'
|
||||
pull_request:
|
||||
pull_request_target:
|
||||
branches:
|
||||
- master
|
||||
paths-ignore:
|
||||
@@ -25,6 +25,10 @@ on:
|
||||
env:
|
||||
BUILD_CONFIGURATION: Release
|
||||
|
||||
permissions:
|
||||
contents: read
|
||||
pull-requests: read
|
||||
|
||||
jobs:
|
||||
build-windows:
|
||||
strategy:
|
||||
|
||||
Reference in new issue
Block a user