Mirror/ppsspp
1
0 Fork 0
mirror of https://github.com/hrydgard/ppsspp.git synced 2026-10-01 14:58:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix memory leak in achievements screen

Browse Source
This commit is contained in:
Henrik Rydgård committed 2026-04-08 10:36:58 -06:00
1 parent 073cd15368
commit b06e2b308c
2 files changed
+18 -10
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

UI/RetroAchievementScreens.cpp
+14 -9
View File
@@ -100,9 +100,6 @@ void CreateAchievementsTab(UI::ViewGroup *achievements, const SubsetInfo &subset
const rc_client_game_t *client_game = rc_client_get_game_info(Achievements::GetClient());
rc_client_achievement_list_t *list = rc_client_create_achievement_list(Achievements::GetClient(),
GetListFilter(), RC_CLIENT_ACHIEVEMENT_LIST_GROUPING_PROGRESS);
if (!subset.isDefault) {
achievements->Add(new Spacer(8.0f));
achievements->Add(new TextView(subset.title))->SetTextSize(UI::TextSize::Big);
@@ -128,8 +125,18 @@ void CreateAchievementsTab(UI::ViewGroup *achievements, const SubsetInfo &subset
section->Add(new AchievementView(bucket.achievements[j]));
}
}
}
rc_client_destroy_achievement_list(list);
RetroAchievementsListScreen::RetroAchievementsListScreen(const Path &gamePath) : UITabbedBaseDialogScreen(gamePath) {
list_ = rc_client_create_achievement_list(Achievements::GetClient(),
GetListFilter(), RC_CLIENT_ACHIEVEMENT_LIST_GROUPING_PROGRESS);
}
RetroAchievementsListScreen::~RetroAchievementsListScreen() {
if (list_) {
rc_client_destroy_achievement_list(list_);
list_ = nullptr;
}
}
void RetroAchievementsListScreen::CreateLeaderboardsTab(UI::ViewGroup *viewGroup) {
@@ -158,6 +165,7 @@ void RetroAchievementsListScreen::CreateLeaderboardsTab(UI::ViewGroup *viewGroup
screenManager()->push(new RetroAchievementsLeaderboardScreen(gamePath_, leaderboardID));
});
}
rc_client_destroy_leaderboard_list(list);
}
void RetroAchievementsListScreen::CreateStatisticsTab(UI::ViewGroup *viewGroup) {
@@ -173,14 +181,11 @@ void RetroAchievementsListScreen::CreateStatisticsTab(UI::ViewGroup *viewGroup)
void RetroAchievementsListScreen::CreateTabs() {
auto ac = GetI18NCategory(I18NCat::ACHIEVEMENTS);
rc_client_achievement_list_t *list = rc_client_create_achievement_list(Achievements::GetClient(),
GetListFilter(), RC_CLIENT_ACHIEVEMENT_LIST_GROUPING_PROGRESS);
std::map<uint32_t, SubsetInfo> bucketsBySubset;
const rc_client_game_t *client_game = rc_client_get_game_info(Achievements::GetClient());
for (uint32_t i = 0; i < list->num_buckets; i++) {
const rc_client_achievement_bucket_t &bucket = list->buckets[i];
for (uint32_t i = 0; i < list_->num_buckets; i++) {
const rc_client_achievement_bucket_t &bucket = list_->buckets[i];
if (!bucket.num_achievements) {
continue;
}
UI/RetroAchievementScreens.h
+4 -1
View File
@@ -15,7 +15,8 @@
// Lists the achievements and leaderboards for one game.
class RetroAchievementsListScreen : public UITabbedBaseDialogScreen {
public:
RetroAchievementsListScreen(const Path &gamePath) : UITabbedBaseDialogScreen(gamePath) {}
RetroAchievementsListScreen(const Path &gamePath);
~RetroAchievementsListScreen();
const char *tag() const override { return "RetroAchievementsListScreen"; }
void CreateTabs() override;
@@ -26,6 +27,8 @@ protected:
private:
void CreateLeaderboardsTab(UI::ViewGroup *viewGroup);
void CreateStatisticsTab(UI::ViewGroup *viewGroup);
rc_client_achievement_list_t *list_ = nullptr;
};
// Lets you manage your account, and shows some achievement stats and stuff.