Mirror/ppsspp
1
0 Fork 0
mirror of https://github.com/hrydgard/ppsspp.git synced 2026-10-01 14:58:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Debugger: Allow currently-invalid memory reference.

Browse Source
This commit is contained in:
Unknown W. Brackets committed 2022-10-29 17:43:35 -07:00
1 parent 8cefb98e97
commit 0a98ac43fa
2 files changed
+19 -32
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

Core/MIPS/MIPSDebugInterface.cpp
+13 -25
View File
@@ -159,37 +159,25 @@ public:
return EXPR_TYPE_UINT;
}
bool getMemoryValue(uint32_t address, int size, uint32_t& dest, char* error) override
{
switch (size)
{
case 1: case 2: case 4:
break;
default:
sprintf(error,"Invalid memory access size %d",size);
return false;
}
bool getMemoryValue(uint32_t address, int size, uint32_t& dest, char* error) override {
// We allow, but ignore, bad access.
// If we didn't, log/condition statements that reference registers couldn't be configured.
bool valid = Memory::IsValidRange(address, size);
if (address % size)
{
sprintf(error,"Invalid memory access (unaligned)");
return false;
}
switch (size)
{
switch (size) {
case 1:
dest = Memory::Read_U8(address);
break;
dest = valid ? Memory::Read_U8(address) : 0;
return true;
case 2:
dest = Memory::Read_U16(address);
break;
dest = valid ? Memory::Read_U16(address) : 0;
return true;
case 4:
dest = Memory::Read_U32(address);
break;
dest = valid ? Memory::Read_U32(address) : 0;
return true;
}
return true;
sprintf(error, "Unexpected memory access size %d", size);
return false;
}
private:
GPU/Common/GPUDebugInterface.cpp
+6 -7
View File
@@ -916,20 +916,19 @@ ExpressionType GEExpressionFunctions::getFieldType(GECmdFormat fmt, GECmdField f
}
bool GEExpressionFunctions::getMemoryValue(uint32_t address, int size, uint32_t &dest, char *error) {
if (!Memory::IsValidRange(address, size)) {
sprintf(error, "Invalid address or size %08x + %d", address, size);
return false;
}
// We allow, but ignore, bad access.
// If we didn't, log/condition statements that reference registers couldn't be configured.
bool valid = Memory::IsValidRange(address, size);
switch (size) {
case 1:
dest = Memory::Read_U8(address);
dest = valid ? Memory::Read_U8(address) : 0;
return true;
case 2:
dest = Memory::Read_U16(address);
dest = valid ? Memory::Read_U16(address) : 0;
return true;
case 4:
dest = Memory::Read_U32(address);
dest = valid ? Memory::Read_U32(address) : 0;
return true;
}