Mirror/ppsspp
1
0 Fork 0
mirror of https://github.com/hrydgard/ppsspp.git synced 2026-10-01 14:58:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Memory safety in sceAtracDecode

Browse Source
This commit is contained in:
Henrik Rydgård committed 2025-05-20 00:43:23 +02:00
1 parent 268962a04e
commit 01ea76ffc7
1 file changed
+6 -1
Download Patch File Download Diff File Expand all files Collapse all files
Core/HLE/sceAtrac.cpp
+6 -1
View File
@@ -325,11 +325,16 @@ static u32 sceAtracDecodeData(int atracID, u32 outAddr, u32 numSamplesAddr, u32
return hleLogError(Log::ME, SCE_ERROR_ATRAC_BAD_ALIGNMENT);
}
int numSamplesWritten = 0;
int finish = 0;
int remains = 0;
if (outAddr != 0 && !Memory::IsValidAddress(outAddr)) {
// Dunno what error code to return here, but we have to bail in this case to avoid crashing PPSSPP.
return hleLogError(Log::ME, SCE_ERROR_ATRAC_SIZE_TOO_SMALL);
}
u8 *outPtr = outAddr ? Memory::GetPointerWrite(outAddr) : nullptr;
int ret = atrac->DecodeData(outPtr, outAddr, &numSamplesWritten, &finish, &remains);
if (ret != (int)SCE_ERROR_ATRAC_BAD_ATRACID && ret != (int)SCE_ERROR_ATRAC_NO_DATA) {
if (Memory::IsValidAddress(numSamplesAddr))