Mirror/eden
1
0 Fork 0
mirror of https://git.eden-emu.dev/eden-emu/eden.git synced 2026-10-01 14:59:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

[dynarmic] fix sign extension logic on x64 (#4415)

Browse Source 
- [x] I have read and followed the [Contribution Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions).
- [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md)
- [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md) to the best of my ability.

-------------------
Co-authored-by: lizzie <[email protected]>

Co-authored-by: lizzie <[email protected]>
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4415
Reviewed-by: lizzie <[email protected]>
Reviewed-by: MaranBr <[email protected]>
This commit is contained in:
Exvergeandlizzie authored and crueter committed 2026-09-15 01:14:31 +02:00
1 parent bfba95fd60
commit 1575f55abe
1 file changed
+10 -4
Download Patch File Download Diff File Expand all files Collapse all files
src/dynarmic/src/dynarmic/backend/x64/emit_x64_memory.h
+10 -4
View File
@@ -85,8 +85,13 @@ template<>
code.mov(tmp, vaddr);
code.shr(tmp, int(page_table_const_bits));
code.shl(tmp, int(ctx.conf.page_table_log2_stride));
code.mov(page, qword[r14 + tmp.cvt64()]);
if (ctx.conf.page_table_log2_stride > 3) {
code.shl(tmp, int(ctx.conf.page_table_log2_stride));
code.mov(page, qword[r14 + tmp.cvt64()]);
} else {
code.mov(page, qword[r14 + tmp.cvt64() * int(ctx.conf.page_table_log2_stride)]);
}
// check for marked bit, use as unmapped if marked
if (ctx.conf.page_table_marked_bit) {
@@ -102,9 +107,10 @@ template<>
code.mov(tmp, ctx.conf.page_table_pointer_mask);
code.and_(page, tmp);
}
// check for sign bit, apply sign extension as needed
if (ctx.conf.page_table_sign_extension) {
code.shl(page, *ctx.conf.page_table_sign_extension);
code.sar(page, *ctx.conf.page_table_sign_extension);
code.shl(page, 63 - int(*ctx.conf.page_table_sign_extension));
code.sar(page, 63 - int(*ctx.conf.page_table_sign_extension));
}
code.jz(abort, code.T_NEAR);