Files
ppsspp/unittest/TestTextureReplacer.cpp
T
Henrik RydgårdandClaude Opus 5.5 b9501df529 TextureReplacer: Fix stale and shared lookup results
- Reloading the ini clears the per-key lookup caches, which could keep
  saying "no replacement" for textures the new ini replaces.
- With ignoreAddress, hash ranges were skipped when sizing the
  replacement, though ComputeHash applies them. cache_ is now keyed by
  the full key, so its lookups hit too.
- Textures sharing files but differing in size, hash range or filtering
  no longer share one ReplacedTexture (the first one's settings won).

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
2026-09-29 13:28:21 -06:00

242 lines
7.3 KiB
C++

#include <cstdio>
#include <cstring>
#include <vector>
#include "Common/Data/Format/PNGLoad.h"
#include "Common/File/FileUtil.h"
#include "Common/File/Path.h"
#include "Common/Thread/ThreadManager.h"
#include "GPU/Common/TextureReplacer.h"
#include "UnitTest.h"
// The fake hashes in textures.ini are designed to be readable: the address
// part starts with A, the CLUT hash with C, and the contents hash with 1.
static const u64 KEY_A = 0xA0000001C0000001ULL; // addr 0xA0000001, clut 0xC0000001
static const u32 HASH_A = 0x10000001;
static const u64 KEY_B = 0xA0000002C0000002ULL; // two mip levels
static const u32 HASH_B = 0x10000002;
static const u64 KEY_C = 0xA0000003C0000003ULL; // hashrange
static const u32 HASH_C = 0x10000003;
static const u64 KEY_D = 0xA0000004C0000004ULL; // ignored (empty filename)
static const u32 HASH_D = 0x10000004;
static const u64 KEY_E = 0xA0000005C0000005ULL; // file missing
static const u32 HASH_E = 0x10000005;
static const u64 KEY_F = 0xA0000006C0000006ULL; // same file as A, own hashrange
static const u32 HASH_F = 0x10000006;
static const u64 KEY_G = 0xA0000007C0000007ULL; // ignoreAddress pack, hashrange
static const u32 HASH_G = 0x10000007;
static bool CreateTestPNG(const Path &filename, int w, int h, u32 color) {
std::vector<u8> buf((size_t)w * h * 4);
for (int i = 0; i < w * h; i++) {
buf[i * 4] = (color >> 24) & 0xFF;
buf[i * 4 + 1] = (color >> 16) & 0xFF;
buf[i * 4 + 2] = (color >> 8) & 0xFF;
buf[i * 4 + 3] = color & 0xFF;
}
return pngSave(filename, buf.data(), w, h, 4);
}
static bool WriteIni(const Path &packDir, const char *iniContent) {
FILE *f = File::OpenCFile(packDir / "textures.ini", "w");
if (!f) {
return false;
}
fwrite(iniContent, 1, strlen(iniContent), f);
fclose(f);
return true;
}
static bool CreateTestPack(const Path &packDir) {
File::DeleteDirRecursively(packDir);
if (!File::CreateDir(packDir)) {
return false;
}
static const char *iniContent =
"[options]\n"
"hash = quick\n"
"version = 1\n"
"\n"
"[hashes]\n"
"A0000001C000000110000001 = tex_a.png\n"
"A0000002C000000210000002 = tex_b0.png\n"
"A0000002C000000210000002_1 = tex_b1.png\n"
"A0000003C000000310000003 = tex_c.png\n"
"A0000004C000000410000004 =\n"
"A0000005C000000510000005 = missing.png\n"
"A0000006C000000610000006 = tex_a.png\n"
"\n"
"[hashranges]\n"
"A0000003,512,512 = 256,256\n"
"A0000006,64,64 = 32,32\n"
"\n"
"[filtering]\n"
"A0000001C000000110000001 = nearest\n";
if (!WriteIni(packDir, iniContent)) {
return false;
}
if (!CreateTestPNG(packDir / "tex_a.png", 64, 64, 0xFF0000FF)) return false;
if (!CreateTestPNG(packDir / "tex_b0.png", 64, 64, 0x00FF00FF)) return false;
if (!CreateTestPNG(packDir / "tex_b1.png", 32, 32, 0x00FF00FF)) return false;
if (!CreateTestPNG(packDir / "tex_c.png", 256, 256, 0x0000FFFF)) return false;
return true;
}
static bool TestLookups(TextureReplacer *replacer) {
// Key A: single mip, found.
ReplacedTexture *texA = replacer->FindReplacement(ReplacementCacheKey(KEY_A, HASH_A), 64, 64);
EXPECT_TRUE(texA != nullptr);
// Key B: two mip levels, found.
ReplacedTexture *texB = replacer->FindReplacement(ReplacementCacheKey(KEY_B, HASH_B), 64, 64);
EXPECT_TRUE(texB != nullptr);
// Key C: found via hashrange.
ReplacedTexture *texC = replacer->FindReplacement(ReplacementCacheKey(KEY_C, HASH_C), 512, 512);
EXPECT_TRUE(texC != nullptr);
// Key D: explicitly ignored (empty filename).
EXPECT_TRUE(replacer->FindReplacement(ReplacementCacheKey(KEY_D, HASH_D), 16, 16) == nullptr);
// Key E: file missing, still creates a texture object (loads as NOT_FOUND).
ReplacedTexture *texE = replacer->FindReplacement(ReplacementCacheKey(KEY_E, HASH_E), 16, 16);
EXPECT_TRUE(texE != nullptr);
// Key F: the same file as A, but its own hashrange and no filtering, so it can't share A's texture.
ReplacedTexture *texF = replacer->FindReplacement(ReplacementCacheKey(KEY_F, HASH_F), 64, 64);
EXPECT_TRUE(texF != nullptr);
EXPECT_TRUE(texF != texA);
// Unknown key: not in the ini at all.
ReplacementCacheKey unknownKey(0x2000000020000000ULL, 0x20000000);
EXPECT_TRUE(replacer->FindReplacement(unknownKey, 16, 16) == nullptr);
if (!texA || !texB || !texC || !texE || !texF) {
return false;
}
// Load the actual textures using the thread manager.
g_threadManager.Init(1, 1);
// Key A: 64x64 single level, nearest filtering.
EXPECT_TRUE(texA->Poll(1.0));
EXPECT_EQ_INT(texA->NumLevels(), 1);
int w = 0, h = 0;
texA->GetSize(0, &w, &h);
EXPECT_EQ_INT(w, 64);
EXPECT_EQ_INT(h, 64);
TextureFiltering filtering = TEX_FILTER_AUTO;
EXPECT_TRUE(texA->ForceFiltering(&filtering));
EXPECT_TRUE(filtering == TEX_FILTER_FORCE_NEAREST);
// Key B: two mip levels, 64x64 and 32x32.
EXPECT_TRUE(texB->Poll(1.0));
EXPECT_EQ_INT(texB->NumLevels(), 2);
texB->GetSize(0, &w, &h);
EXPECT_EQ_INT(w, 64);
EXPECT_EQ_INT(h, 64);
texB->GetSize(1, &w, &h);
EXPECT_EQ_INT(w, 32);
EXPECT_EQ_INT(h, 32);
// Key C: hashrange maps 512x512 -> 256x256, upscaled back to 512x512.
EXPECT_TRUE(texC->Poll(1.0));
EXPECT_EQ_INT(texC->NumLevels(), 1);
texC->GetSize(0, &w, &h);
EXPECT_EQ_INT(w, 512);
EXPECT_EQ_INT(h, 512);
// Key F: hashrange maps 64x64 -> 32x32, so the 64x64 image covers 128x128.
EXPECT_TRUE(texF->Poll(1.0));
texF->GetSize(0, &w, &h);
EXPECT_EQ_INT(w, 128);
EXPECT_EQ_INT(h, 128);
EXPECT_FALSE(texF->ForceFiltering(&filtering));
// Key E: missing file should end up NOT_FOUND.
EXPECT_TRUE(texE->Poll(1.0));
EXPECT_TRUE(texE->State() == ReplacementState::NOT_FOUND);
g_threadManager.Teardown();
return true;
}
// ignoreAddress matches files without the address, but hash ranges still apply per address.
static bool TestIgnoreAddress(const Path &packDir) {
static const char *iniContent =
"[options]\n"
"hash = xxh32\n"
"ignoreAddress = true\n"
"version = 1\n"
"\n"
"[hashes]\n"
"00000000C000000710000007 = tex_c.png\n"
"\n"
"[hashranges]\n"
"A0000007,512,512 = 256,256\n";
if (!WriteIni(packDir, iniContent)) {
return false;
}
TextureReplacer replacer(nullptr);
std::string error;
if (!replacer.LoadPackForTesting(packDir, &error)) {
return false;
}
ReplacementCacheKey key(KEY_G, HASH_G);
ReplacedTexture *texG = replacer.FindReplacement(key, 512, 512);
EXPECT_TRUE(texG != nullptr);
if (!texG) {
return false;
}
EXPECT_TRUE(replacer.FindReplacement(key, 512, 512) == texG);
g_threadManager.Init(1, 1);
EXPECT_TRUE(texG->Poll(1.0));
int w = 0, h = 0;
texG->GetSize(0, &w, &h);
EXPECT_EQ_INT(w, 512);
EXPECT_EQ_INT(h, 512);
g_threadManager.Teardown();
return true;
}
bool TestTextureReplacer() {
Path packDir = Path("unittest_texture_pack");
if (!CreateTestPack(packDir)) {
return false;
}
TextureReplacer replacer(nullptr);
std::string error;
if (!replacer.LoadPackForTesting(packDir, &error)) {
ERROR_LOG(Log::G3D, "Failed to load test texture pack: %s", error.c_str());
File::DeleteDirRecursively(packDir);
return false;
}
if (!TestLookups(&replacer)) {
File::DeleteDirRecursively(packDir);
return false;
}
// Reloading the ini forgets what the old one said about each texture.
EXPECT_TRUE(replacer.GetNumTrackedTextures() != 0);
EXPECT_TRUE(replacer.LoadPackForTesting(packDir, &error));
EXPECT_EQ_INT(replacer.GetNumTrackedTextures(), 0);
if (!TestIgnoreAddress(packDir)) {
File::DeleteDirRecursively(packDir);
return false;
}
File::DeleteDirRecursively(packDir);
return true;
}