From ffe05bdf58f0f59413fce0e551da4e0df997926b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Henrik=20Rydg=C3=A5rd?= Date: Tue, 12 Nov 2024 12:14:07 +0100 Subject: [PATCH] Memmap error message improvements --- Core/MemMap.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Core/MemMap.cpp b/Core/MemMap.cpp index 67bbe6f9f3..26182005f5 100644 --- a/Core/MemMap.cpp +++ b/Core/MemMap.cpp @@ -158,8 +158,8 @@ static bool Memory_TryBase(u32 flags) { *view.out_ptr = (u8*)g_arena.CreateView( position, view.size, base + view.virtual_address); if (!*view.out_ptr) { + ERROR_LOG(Log::MemMap, "Failed at view %d", i); goto bail; - DEBUG_LOG(Log::MemMap, "Failed at view %d", i); } #else if (CanIgnoreView(view)) { @@ -169,7 +169,7 @@ static bool Memory_TryBase(u32 flags) { *view.out_ptr = (u8*)g_arena.CreateView( position, view.size, base + (view.virtual_address & MEMVIEW32_MASK)); if (!*view.out_ptr) { - DEBUG_LOG(Log::MemMap, "Failed at view %d", i); + ERROR_LOG(Log::MemMap, "Failed at view %d", i); goto bail; } } @@ -185,11 +185,11 @@ bail: if (views[i].size == 0) continue; SKIP(flags, views[i].flags); - if (*views[j].out_ptr) { + if (views[j].out_ptr && *views[j].out_ptr) { if (!CanIgnoreView(views[j])) { g_arena.ReleaseView(0, *views[j].out_ptr, views[j].size); } - *views[j].out_ptr = NULL; + *views[j].out_ptr = nullptr; } } return false;