From 8d98c39b1f734a559bf2c3b82f5c3ec6be87fa60 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Henrik=20Rydg=C3=A5rd?= Date: Wed, 30 Sep 2026 11:27:02 -0600 Subject: [PATCH] Achievements: Don't pass a null error message to %s error_message is null on success, which is when these two lines log. Co-Authored-By: Claude Opus 5.5 (1M context) --- Core/RetroAchievements.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Core/RetroAchievements.cpp b/Core/RetroAchievements.cpp index 5c1c99787c..33427fd993 100644 --- a/Core/RetroAchievements.cpp +++ b/Core/RetroAchievements.cpp @@ -1135,7 +1135,7 @@ void ShowNotLoggedInMessage() { void identify_and_load_callback(int result, const char *error_message, rc_client_t *client, void *userdata) { auto ac = GetI18NCategory(I18NCat::ACHIEVEMENTS); - NOTICE_LOG(Log::Achievements, "Load callback: %d (%s)", result, error_message); + NOTICE_LOG(Log::Achievements, "Load callback: %d (%s)", result, error_message ? error_message : ""); switch (result) { case RC_OK: @@ -1273,7 +1273,7 @@ void UnloadGame() { void change_media_callback(int result, const char *error_message, rc_client_t *client, void *userdata) { auto ac = GetI18NCategory(I18NCat::ACHIEVEMENTS); - NOTICE_LOG(Log::Achievements, "Change media callback: %d (%s)", result, error_message); + NOTICE_LOG(Log::Achievements, "Change media callback: %d (%s)", result, error_message ? error_message : ""); g_isIdentifying = false; switch (result) {