From 74c5cbf503c5f46bb039ef7e99bd14fec8dd0e4d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Henrik=20Rydg=C3=A5rd?= Date: Tue, 22 Sep 2026 15:56:52 -0600 Subject: [PATCH] Savedata: Leave GetSize's needed strings alone when nothing is needed Matches hardware; moves utility/savedata/getsize to tests_good. Co-Authored-By: Claude Opus 5.5 (1M context) --- Core/Dialog/SavedataParam.cpp | 4 +--- test.py | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/Core/Dialog/SavedataParam.cpp b/Core/Dialog/SavedataParam.cpp index fe6b2a3558..6c5271b416 100644 --- a/Core/Dialog/SavedataParam.cpp +++ b/Core/Dialog/SavedataParam.cpp @@ -1450,9 +1450,7 @@ bool SavedataParam::GetSize(SceUtilitySavedataParam *param) { // Note: this is "needed to overwrite". param->sizeInfo->overwriteKB = 0; - spaceTxt = GetSpaceText(0, true); - truncate_cpy(param->sizeInfo->neededString, spaceTxt); - truncate_cpy(param->sizeInfo->overwriteString, spaceTxt); + // The strings are left alone when nothing is needed (tests/utility/savedata/getsize). } else { // Bytes needed to save additional data. s64 neededBytes = writeBytes - freeBytes; diff --git a/test.py b/test.py index 5024da381e..165a52d533 100755 --- a/test.py +++ b/test.py @@ -423,6 +423,7 @@ tests_good = [ "utility/msgdialog/abort", "utility/savedata/autosave", "utility/savedata/filelist", + "utility/savedata/getsize", "utility/savedata/makedata", "utility/systemparam/systemparam", "umd/callbacks/umd", @@ -582,7 +583,6 @@ tests_next = [ "umd/raw_access/raw_access", "umd/wait/wait", "utility/msgdialog/dialog", - "utility/savedata/getsize", "utility/savedata/idlist", # These tests appear to be broken and just hang. #"utility/savedata/deletebroken",