From 2396ac7acbe880f48cffa5f5462e4f2d51b60ced Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Henrik=20Rydg=C3=A5rd?= Date: Sun, 23 Aug 2026 15:46:53 +0200 Subject: [PATCH] Libretro buildfix: drop WebSocket stubs duplicating the inline ones in the header 0ed6b97921 added inline no-op stubs to WebSocket.h under __LIBRETRO__, but the older non-inline ones in libretro.cpp stayed, so every libretro build has had two definitions of each. gcc/clang inline the trivial bodies away and emit no symbol, so it only shows up with MSVC, as LNK2005 against Core.o/Breakpoints.o. Co-Authored-By: Claude Opus 5 (1M context) Claude-Session: https://claude.ai/code/session_01FzzCUp8y1ahgVueb1Cq92Y --- libretro/libretro.cpp | 5 ----- 1 file changed, 5 deletions(-) diff --git a/libretro/libretro.cpp b/libretro/libretro.cpp index fa61e2b317..c55b2d4065 100644 --- a/libretro/libretro.cpp +++ b/libretro/libretro.cpp @@ -1984,11 +1984,6 @@ void System_PostUIMessage(UIMessage message, std::string_view param) {} void System_RunOnMainThread(std::function) {} void NativeFrame(GraphicsContext *graphicsContext) {} void NativeResized() {} -// Stubs to let things link - libretro builds Core.cpp and Breakpoints.cpp, which call into the -// WebSocket debugger, but doesn't build Core/Debugger/WebSocket.cpp itself. -void WebSocketDebuggerTick() {} -bool WebSocketDebuggerHasClients() { return false; } -void WebSocketNotifyBreakpointHit(const BreakpointHit &hit) {} void System_Toast(std::string_view str) {} inline int16_t Clamp16(int32_t sample) {