From 7c49b701073932a3b743bc63d6d3ca53c9da8f12 Mon Sep 17 00:00:00 2001 From: MaranBr Date: Thu, 1 Oct 2026 10:35:37 -0400 Subject: [PATCH] Minor improvement --- src/shader_recompiler/ir_opt/passes.h | 2 +- src/shader_recompiler/ir_opt/vendor_workaround_pass.cpp | 2 +- src/video_core/renderer_vulkan/vk_pipeline_cache.cpp | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/shader_recompiler/ir_opt/passes.h b/src/shader_recompiler/ir_opt/passes.h index 64a008c40a..068d7fdfe8 100644 --- a/src/shader_recompiler/ir_opt/passes.h +++ b/src/shader_recompiler/ir_opt/passes.h @@ -30,8 +30,8 @@ void PositionPass(Environment& env, IR::Program& program); void TexturePass(Environment& env, IR::Program& program, const HostTranslateInfo& host_info); void LayerPass(IR::Program& program, const HostTranslateInfo& host_info); void VendorWorkaroundPass(IR::Program& program); -bool HasProblematicFragmentShaderPattern(const IR::Program& program); void VerificationPass(const IR::Program& program); +bool HasBrokenPattern(const IR::Program& program); // Dual Vertex void VertexATransformPass(IR::Program& program); diff --git a/src/shader_recompiler/ir_opt/vendor_workaround_pass.cpp b/src/shader_recompiler/ir_opt/vendor_workaround_pass.cpp index 198864c2e7..5842f6135b 100644 --- a/src/shader_recompiler/ir_opt/vendor_workaround_pass.cpp +++ b/src/shader_recompiler/ir_opt/vendor_workaround_pass.cpp @@ -79,7 +79,7 @@ void VendorWorkaroundPass(IR::Program& program) { } } -bool HasProblematicFragmentShaderPattern(const IR::Program& program) { +bool HasBrokenPattern(const IR::Program& program) { if (program.stage != Stage::Fragment) { return false; } diff --git a/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp b/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp index 53b87ca289..ff562b24b6 100644 --- a/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp +++ b/src/video_core/renderer_vulkan/vk_pipeline_cache.cpp @@ -827,8 +827,8 @@ std::unique_ptr PipelineCache::CreateGraphicsPipeline( programs[index] = MergeDualVertexPrograms(program_va, program_vb, env); } - if (device.GetDriverID() != VK_DRIVER_ID_NVIDIA_PROPRIETARY && Shader::Optimization::HasProblematicFragmentShaderPattern(programs[index])) { - LOG_WARNING(Render_Vulkan, "0x{:016x}: Skipping incompatible fragment shader.", key.unique_hashes[index]); + if (device.GetDriverID() != VK_DRIVER_ID_NVIDIA_PROPRIETARY && Shader::Optimization::HasBrokenPattern(programs[index])) { + LOG_WARNING(Render_Vulkan, "0x{:016x}: Skipping shader with broken pattern", key.unique_hashes[index]); return nullptr; }